[#43783] - MFA and Silent Logins
- Closed
- 13 Jul 2024
- Medium
- Build: 4.4-dev
- # 43783
- Diff
- leeroy1821:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #42308 .
Summary of Changes
Update \Joomla\Plugin\System\Webauthn\PluginTraits\AjaxHandlerLogin. Fix loading user plugins (b/c break). Fix wrong events constructors (missing subject, wrong argument order). Fix triggering events (wrong event name passed).
Testing Instructions
- Create user with MFA and passkey login
- Users, Manage, Options, Multi-factor Authentication, Multi-factor Authentication after silent login => No.
- Log out
- Log in with passkey
Actual result BEFORE applying this Pull Request
Joomla! asks for MFA
Expected result AFTER applying this Pull Request
Joomla does not ask for MFA
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
PR-4.4-dev
|
||
@brianteeman Misunderstood. This fixes problem caused by a (maybe?) b/c break in 5.0. It does not cause new b/c break.
This should be for 5.2, not for 4.4. I will close and retry.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-13 12:46:48 |
| Closed_By | ⇒ | leeroy1821 |
This should be for 5.2, not for 4.4. I will close and retry.
@leeroy1821 If it's a new feature it should go into 5.2. But if it's a bug fix, the 4.4-dev branch would be ok. Maintainers later would merge it up into the 5.x-dev and 6.0-dev branches.
@richard67 No, this fixes issue #42308 which is in only Joomla 5.0, 5.1, 5.2. I am sorry, I made a mistake in this PR. I used wrong branch in GitHub. Correct PR => #43790
@richard67 No, this fixes issue #42308 which is in only Joomla 5.0, 5.1, 5.2. I am sorry, I made a mistake in this PR. I used wrong branch in GitHub. Correct PR => #43790
@leeroy1821 If it's a bug which exists in 5.0 and 5.1 the PR should be made for the 5.1-dev branch.
As you have stated that this is a b/c break then it cannot go in 4.4