[#43781] - [5.3] Move to ESM
- Closed
- 17 Oct 2024
- Medium
- Build: 5.1-dev
- # 43781
- Diff
- dgrammatiko:esm
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Move tools and source JS to ESM
- ES6 files have now the extension
.mjs(used to be.es6.js) - Legacy js files now have a
.jsextension instead of.es5.js - Web Components also have
.mjsextension (used to be.w-c.es6.js) - The
build/media_source/system/js/joomla-core-loader.mjsfile now includes the required css and the relatedbuild/media_source/system/scss/joomla-core-loader.scssis deleted
Testing Instructions
You need Git and NPM to test this
Pull the 4.4-dev branch and run:
npm installnpm run cssversioningnpm run gzipnpm run versioning- Store the media folder somewhere outside of the
joomla-cmsfolder
Pull this PR gh pr checkout 43779 and run:
npm installnpm run cssversioningnpm run gzipnpm run versioning- Store the media folder somewhere outside of the
joomla-cmsfolder
Compare the two folders. The only difference should be the missing files: media/system/css/joomla-core-loader.css, media/system/css/joomla-core-loader.min.css, media/system/css/joomla-core-loader.min.css.gz
Check the basic backend functionality
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
@Fedik @richard67 could you please test this one (pretty hard for the average tester)?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change Repository |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
| Category | JavaScript Administration com_media NPM Change Repository | ⇒ | JavaScript Administration com_media NPM Change |
Hey, at least there are clear test instructions ?
I would keep settings.json as it is now. To avoid bloating of package.json.
Other than that, the PR seems working, node comands still working.
I would keep settings.json as it is now. To avoid bloating of package.json.
It can be reverted, although personally I see that the settings in the package is easier than searching for some file that all the settings are stored.
Anyways not too strong opinion here, I would revert it
Yes please.
It is better to keep them apart, there mostly joomla stuff, nothing standart for package.json
And it really huge.
Ok, done
I have tested this item ✅ successfully on 46da720
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43781.
Why not just use "type": "module" in the package.json instead of using .mjs files?
instead of using .mjs files
Couple reasons:
- existing common js files will need to be renamed to
.cjs - most important, this simplifies the whole thing:
.mjsmodern js,.jslegacy, iife staff
Oh you still have CJS. Fair enough.
I don't understanding mixing .cjs, .mjs and .js in 2024, as Node.js has supported ES Modules for ages.
I don't understanding mixing .cjs, .mjs and .js in 2024, as Node.js has supported ES Modules for ages.
Actually what I'm doing here is using the mjs/js extensions as a convention for the tools.
Could it be done with just the js extension?
Sure by using some prefix like we did .es6.js but since these are the source files (not deliverables) it's up to the maintainers to choose their poison (the point is that I've eliminated one case here the .w-c.js, now covered by .mjs) a 3 letter extension (mjs) or a 6 one (es6.js). FWIW .mjs is totally supported by node (actually was invented for cases where there were more than ESM files, ie current Joomla's case)...
Is there any interest on this one or should I close it?
or should I close it?
hold on, not so fast ?
This should be something in Joomla! but sorry, not in a Bugfix release. Moved it to 5.2.
| Category | JavaScript Administration com_media NPM Change | ⇒ | Repository JavaScript |
Ok, I reduced the changes only to the tools.
The source folder needs coordination as any conflicts are painful to be fixed. I'm ok with doing the work if the maintainers accept the changes and coordinate the RL so I don't have to fight unmerges etc...
Quy
- | Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-12 12:28:07 |
| Closed_By | ⇒ | dgrammatiko | |
| Labels |
Added:
PR-5.2-dev
Removed: NPM Resource Changed PR-5.1-dev |
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2024-08-12 12:28:07 | ⇒ | |
| Closed_By | dgrammatiko | ⇒ |
| Status | New | ⇒ | Pending |
@dgrammatiko please reset the changes in settings.json, as I see it is only formating, I do not realy want it to affect the history.
Thanks!
pe7er
- | Title |
|
||||||
| Labels |
Added:
Feature
PR-5.3-dev
Removed: PR-5.2-dev |
||
| Category | JavaScript Repository | ⇒ | Administration Language & Strings Installation Libraries NPM Change |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-17 10:11:34 |
| Closed_By | ⇒ | dgrammatiko | |
| Labels |
Added:
Language Change
NPM Resource Changed
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2024-10-17 10:11:34 | ⇒ | |
| Closed_By | dgrammatiko | ⇒ |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-17 10:16:09 |
| Closed_By | ⇒ | dgrammatiko |