[#43755] - [4.4][bugfix] Use iife for the scripts core and validate
- Fixed in Code Base
- 1 Aug 2024
- Medium
- Build: 4.4-dev
- # 43755
- Diff
- dgrammatiko:iife
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #43714 .
Summary of Changes
Use iife instead of esm for the scripts core and validate
Testing Instructions
- Apply the PR
- run
npm install - Check that authenticating in the administrator works
- Create a new article, don't add anything and press save, the validation error should appear
- still in the article edit view, open the browser console, and type
const initialize = 1;and hit Enter.
Before: Error SyntaxError: Identifier 'initialize' has already been declared
After: No error
Actual result BEFORE applying this Pull Request
Leaking variables in the global scope
Expected result AFTER applying this Pull Request
NO leaking variables in the global scope
Link to documentations
Please select:
-
[] Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
PR-4.4-dev
|
||
| Labels |
Added:
bug
|
||
hmhm, nope, sorry, it does not work. The variables in the file still globally available.
'use strict' just forcing developer to use var, const, let, and some other litle things.
It should be anonymous function wrapper.
But it is not possible, because we have import punycode from 'punycode'; (this will throw rollup/babel compilation error).
Need to hack the rollup/babel somehow ?
I have no other ideas.
No, Ignore me ?
It works, but, wee need to set some globals back. please add:
window.JFormValidator = JFormValidator;
window.punycode = punycode;Someone may use it in their scripts, even though punycode not officially shipped.
Maybe with some comment, that it will be removed in future.
Classes exposed to the global scope
I have tested this item ✅ successfully on 348daed
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43755.
For testing.
Open Article editing, open browser console, and type const initialize = 1; and hit Enter.
Before:
Error SyntaxError: Identifier 'initialize' has already been declared
After:
No error;
I have tested this item ✅ successfully on 348daed
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43755.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43755.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-01 22:15:17 |
| Closed_By | ⇒ | MacJoom |
Thank you!
thanks! I will test it later