[#43722] - [4.4] Use joomla-cypress 1.1.1
- Fixed in Code Base
- 7 Aug 2024
- Medium
- Build: 4.4-dev
- # 43722
- Diff
- muhme:joomla-cypress-update
User tests: Successful: Unsuccessful:
Summary of Changes
Revised after 27 commits on 7 August 2024
The goal is to use the NPM joomla-cypress version 1.1.1 for all four active joomla-cms branches. Actual 4.4-dev uses 0.0.16; and 5.1-dev, 5.2-dev and 6.0-dev are using 1.0.3.
The following changes have already been separated from this PR and have already been merged into 4.4-dev:
Also released is NPM package joomla-cypress as version 1.1.1. ?
Change:
- The joomla-cypress version is set to ^1.1.1, so - among other things - the check for PHP warnings is activated again.
- The Cypress commands overwritten by System Tests for a faster session-based login have been removed as they are included in joomla-cypress version 1.1.1.
- The note about overwritten commands in tests/System/README.md is deleted.
joomla-cypress was updated, BUT there are more changes in package-lock.json.
- Reasons are
- Dependend packages like
cypressandcypress-file-upload package.jsonandpackage-lock.jsonwere not in-sync. For example inpackage.jsonthe version is stated as '4.4.7' and inpackage-lock.jsonas '4.4.6'.
- Dependend packages like
Successfully retested with all System Tests passed on 7 Agust 2024 after 27 commits:
- on Intel macOS 14.5 Sonoma with PHP 8.3.9
- on Intel Windows 11 Pro with Laragon and PHP 8.1.10
- on Intel x86_64 Ubuntu 24.04 LTS Noble Numbat with PHP 8.3.6
Testing Instructions
- Install (in using
npm ci) and run System Tests w/o errors - Check version is 1.1.1 in
node_modules/joomla-cypress/package.json - Check that the additional updates in the
package-lock.jsonfile had no effect.
Actual result BEFORE applying this Pull Request
- System Tests is using joomla-cypress version 0.0.16 and a custom implementation of the faster session-based login
- No checks of PHP warnings
- System Tests suite is running without errors
Expected result AFTER applying this Pull Request
- System Tests is using joomla-cypress actual version 1.1.1 and its session-based login
- PHP warning checks are activated again
- System Tests suite is running without errors
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Up-Merging
@LadySolveig @bembelimen I will create a separate different PR for 5.1-dev
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | NPM Change JavaScript Unit Tests |
@muhme Which command have you used to update the dependency? To me it seems this PR updates more dependencies than only joomla-cypress and it’s dependencies.
@richard67 npm update to stay up-to-date with all dependencies. Should it changed to only update joomla-cypress and it’s dependencies?
And to update all dependencies without even mentioning it in the description of this PR would not be good anyway.
@richard67 Since the creation of this PR, the following statement has been included in the description:
npm update, see differences in package-lock.json.
The fact that all packages are updated is therefore explicitly named from my point of view and even provided with a visual eye-catcher. Also, the following instruction was added to the "Test Instructions" section since this PR was created:
- Check that there were no effects from the updates in the NPM packages.
Could it be that you haven't read the description, or am I the one who's in the wrong movie? ?
| Labels |
Added:
Unit/System Tests
NPM Resource Changed
PR-4.4-dev
|
||
| Category | NPM Change JavaScript Unit Tests | ⇒ | Front End com_newsfeeds NPM Change JavaScript Unit Tests |
| Category | NPM Change JavaScript Unit Tests Front End com_newsfeeds | ⇒ | Front End com_newsfeeds NPM Change Unit Tests Repository JavaScript |
Reverted to "Ready to merge", the description has been completely revised after all changes.
Are the changes in the View classes really needed?
Are the changes in the View classes really needed?
In 4.4-dev with joomla-cypress 0.0.16 the PHP message and warningas checks were disabled. With joomla-cypress 1.1.0 they are enabled and the System tests had 6 failures. At first there were workaround 'hacks' in the system tests to get the test suite running without errors. @alikon solved all system test 'hacks' by backporting and investigating. @alikon: Can you explain more in detail?
If these are bugs in the code, we should do them separate and then they need also two human tests.
Golden rule - solve one issue with one pull request
| Title |
|
||||||
| Title |
|
||||||
| Category | NPM Change JavaScript Unit Tests Front End com_newsfeeds Repository | ⇒ | NPM Change Unit Tests Repository JavaScript |
As the other pr's are merged, can this one be changed to ready?
As the other pr's are merged, can this one be changed to ready?
No, it's intentionally set to 'Draft'. I would prefer to wait for the release of joomla-cypress 1.1.1 and then update this PR, set it on 'Ready to Merge' and create separate PR for all other branches, ok?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-07 16:41:17 |
| Closed_By | ⇒ | laoneo |
Thanks!
I have tested this item ✅ successfully on 9a66d94
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43722.