PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar muhme
muhme
25 Jun 2024

Summary of Changes

With PR #43676 '[4.4] Move the Cypress Tests to ESM' the Cypress config file is changed to cypress.config.mjs. There are places in source code tree with the old file names *.js, that are handled by:

  1. In the script used to build Joomla distribution archive packages, in the ignore file list, the Cypress config file name has been changed to the new cypress.config.dist.mjs.
    2. In the delete-file-that-should-not-exist list, cypress.config.mjsand cypress.config.dist.mjs have been added. -> see conversation

⚠️ I am not familar with the workflows of creating Joomla distribution archive packages and deleting files that should not exist. If you have any doubts, please leave a comment.

Testing Instructions

⚠️ I have not tested anything. The changes look very small and clear. But you never know. I therefore ask for your support in testing the two changes.

  • building Joomla distribution archive package and check cypress.config.dist.mjs is not packed
  • Run deleteUnexistingFiles from ??? and check old cypress.config.js and cypress.config.dist.js are deleted; new files cypress.config.mjs and cypress.config.dist.mjs are deleted too.

Actual result BEFORE applying this Pull Request

  • cypress.config.dist.mjs is not ignored in building Joomla distribution archive package
  • cypress.config.mjs and cypress.config.dist.mjs are not deleted on deleting files that should not exist

Expected result AFTER applying this Pull Request

  • cypress.config.dist.mjs is ignored in building Joomla distribution archive package
  • cypress.config.mjs and cypress.config.dist.mjs, as well as cypress.config.js and cypress.config.dist.js are deleted on deleting files that should not exist

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar muhme muhme - open - 25 Jun 2024
avatar muhme muhme - change - 25 Jun 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2024
Category Administration com_admin Repository
avatar muhme muhme - change - 26 Jun 2024
Labels Added: PR-4.4-dev
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jun 2024
Category Administration com_admin Repository Repository
avatar muhme muhme - change - 26 Jun 2024
The description was changed
avatar muhme muhme - edited - 26 Jun 2024
avatar laoneo laoneo - change - 26 Jun 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-06-26 09:46:12
Closed_By laoneo
avatar laoneo laoneo - close - 26 Jun 2024
avatar laoneo laoneo - merge - 26 Jun 2024
avatar laoneo
laoneo - comment - 26 Jun 2024

Thanks!

Add a Comment

Login with GitHub to post a comment