Unit/System Tests NPM Resource Changed PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar muhme
muhme
25 Jun 2024

After PR #43676 '[4.4] Move the Cypress Tests to ESM' the Cypress config file is renamed to cypress.config.mjs. This PR is for updating README, architecture pictures and the Cypress run option in package.json.

Summary of Changes

  1. Update file names cypress.config.mjs and cypress.config.dist.mjs in README and architecture pictures.
  2. Update README with Cypress defineConfig() syntax for new ESM
  3. Explicit name --config-file cypress.config.mjs in package.json to have the new file name in error messages. As this does not work for npx cypress, all given commands are changed to use npm run cypress in README.

Testing Instructions

  • Check all usage of cypress.config.js and cypress.config.dist.js are updated.
  • Check all npx commands are replaces by correct npm run
  • Check all changes, something missing?

Actual result BEFORE applying this Pull Request

  • tests/System/README.md and the used architecture pictures are documenting cypress.config.js and cypress.config.dist.js
  • npx for running Cypress in the code samples

Expected result AFTER applying this Pull Request

  • tests/System/README.md and the used architecture pictures are documenting cypress.config.mjs and cypress.config.dist.mjs
  • npm run for running Cypress in the code samples

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Note

There are other places with cypress.config.js and cypress.config.dist.js in the source code, which will be covered in a follow-up PR.

avatar muhme muhme - open - 25 Jun 2024
avatar muhme muhme - change - 25 Jun 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2024
Category NPM Change Unit Tests Repository
avatar alikon alikon - test_item - 25 Jun 2024 - Tested successfully
avatar alikon
alikon - comment - 25 Jun 2024

I have tested this item ✅ successfully on 45325eb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43702.

avatar laoneo laoneo - change - 26 Jun 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-06-26 07:36:45
Closed_By laoneo
Labels Added: Unit/System Tests NPM Resource Changed PR-4.4-dev
avatar laoneo laoneo - close - 26 Jun 2024
avatar laoneo laoneo - merge - 26 Jun 2024
avatar laoneo
laoneo - comment - 26 Jun 2024

Thanks!

Add a Comment

Login with GitHub to post a comment