NPM Resource Changed bug PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
15 Jun 2024

Pull Request for Issue #40160

Summary of Changes

Fix radio and checkboxes in nested subform field

Testing Instructions

Run npm install.

Add following XML for subform field, somewhere, example in Custom HTML module.
And check that Radio buttons and Checkboxes works.

<field type="subform" name="subform" label="subform" multiple="true">
    <form>
        <field type="text" name="text" label="Text" />
        <field name="radioTop" type="radio" label="Radio top">
            <option value="0">JNO</option>
            <option value="1">JYES</option>
        </field>
        <field name="check" type="checkboxes" label="Checkboxes">
            <option value="0">JNO</option>
            <option value="1">JYES</option>
        </field>
        <field name="checkOne" type="checkbox" label="Checkbox"/>

        <field type="subform" name="nested_subform" label="nested subform" multiple="true">
            <form>
                <field type="text" name="nested_text" label="Nested Text" />
                <field name="radioNested" type="radio" label="Nested Radio">
                    <option value="0">JNO</option>
                    <option value="1">JYES</option>
                </field>
                <field name="checkNested" type="checkboxes" label="Nested checkboxes">
                    <option value="0">JNO</option>
                    <option value="1">JYES</option>
                </field>
                <field name="checkOneNested" type="checkbox" label="Nested Checkbox"/>
            </form>
        </field>
    </form>
</field>

Actual result BEFORE applying this Pull Request

Radio buttons and checkboxes in nested subform does not get checked when click on its label.

Expected result AFTER applying this Pull Request

All radio buttons and checkboxes works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 15 Jun 2024
avatar Fedik Fedik - change - 15 Jun 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2024
Category JavaScript Repository NPM Change
avatar Fedik Fedik - change - 15 Jun 2024
Labels Added: NPM Resource Changed bug PR-5.1-dev
ff2e65c 18 Jun 2024 avatar Fedik fix
avatar RickR2H RickR2H - test_item - 28 Jun 2024 - Tested successfully
avatar RickR2H
RickR2H - comment - 28 Jun 2024

I have tested this item ✅ successfully on ff2e65c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43660.

avatar LadySolveig LadySolveig - test_item - 3 Jul 2024 - Tested successfully
avatar LadySolveig
LadySolveig - comment - 3 Jul 2024

I have tested this item ✅ successfully on 0d69a50


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43660.

avatar bembelimen bembelimen - change - 3 Jul 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-07-03 12:57:10
Closed_By bembelimen
avatar bembelimen bembelimen - close - 3 Jul 2024
avatar bembelimen bembelimen - merge - 3 Jul 2024
avatar bembelimen
bembelimen - comment - 3 Jul 2024

Thx

Add a Comment

Login with GitHub to post a comment