Feature RTC PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
9 Jun 2024

Summary of Changes

Update actionlog plugins to use SubscriberInterface and event classes.
And adding a couple missing events for User pw reset.

Testing Instructions

Check that actionlog works as before.
Test User reset requests, should work as before.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 9 Jun 2024
avatar Fedik Fedik - change - 9 Jun 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jun 2024
Category Libraries Front End Plugins
avatar exlemor exlemor - test_item - 23 Jul 2024 - Tested successfully
avatar exlemor
exlemor - comment - 23 Jul 2024

I have tested this item ✅ successfully on d6ff121

I was able to test this successfully.

I did an incorrect login which ended up in the action log, I did a full user reset which works perfectly (but no trace in the logs which I believe is standard).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43639.

avatar rdeutz
rdeutz - comment - 24 Jul 2024

LGTM on Code Review

avatar Hackwar Hackwar - change - 24 Jul 2024
Labels Added: Feature PR-5.2-dev
avatar Hackwar Hackwar - change - 24 Jul 2024
Status Pending Ready to Commit
avatar Hackwar Hackwar - change - 26 Jul 2024
Labels Added: RTC
avatar Hackwar
Hackwar - comment - 26 Jul 2024

Thank you @Fedik for your contribution! ?

avatar Hackwar Hackwar - change - 26 Jul 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-07-26 14:18:23
Closed_By Hackwar
avatar Hackwar Hackwar - close - 26 Jul 2024
avatar Hackwar Hackwar - merge - 26 Jul 2024

Add a Comment

Login with GitHub to post a comment