RTC bug PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
5 Jun 2024

Summary of Changes

I noticed that the layout of the modal-select form field declares the $onchange option, but does not use it. This PR fixes that. I'm not sure if this is a new feature or a bugfix, since it fixes a broken behavior, but could also be judged as a new feature? I created it for 5.1 for now.

Testing Instructions

Edit a filter form like administrator/components/com_content/forms/filter_articles.xml and add a modal select field here. One example would be the following:

			<field
				name="test"
				type="article"
				label="COM_CONTENT_FIELD_SELECT_ARTICLE_LABEL"
				required="true"
				select="true"
				new="true"
				edit="true"
				clear="true"
				onchange="this.form.submit();"
			/>

(You have to add addfieldprefix="Joomla\Component\Content\Administrator\Field" to the <fieldset> of that XML, too.)

Go to the article list view in the backend and select an article from the modal.

Actual result BEFORE applying this Pull Request

Article is selected, nothing happens otherwise.

Expected result AFTER applying this Pull Request

Article is selected, the filter form is submitted and the page is reloading. (Since there is no filter for this on the server side, the request doesn't change anything, but the onchange event is properly fired.)

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 5 Jun 2024
avatar Hackwar Hackwar - change - 5 Jun 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jun 2024
Category Layout
avatar HLeithner
HLeithner - comment - 5 Jun 2024

We should not use inline javascript anymore

avatar Hackwar
Hackwar - comment - 5 Jun 2024

Sure, but as long as we have this option everywhere else, we should also keep it consistent.

avatar HLeithner HLeithner - test_item - 13 Jun 2024 - Tested successfully
avatar HLeithner
HLeithner - comment - 13 Jun 2024

I have tested this item ✅ successfully on 992cc09


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43618.

avatar viocassel viocassel - test_item - 18 Jun 2024 - Tested successfully
avatar viocassel
viocassel - comment - 18 Jun 2024

I have tested this item ✅ successfully on 992cc09


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43618.

avatar Quy Quy - change - 18 Jun 2024
Status Pending Ready to Commit
Labels Added: NPM Resource Changed PR-5.1-dev
avatar Quy
Quy - comment - 18 Jun 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43618.

avatar Quy Quy - change - 18 Jun 2024
Labels Added: RTC bug
avatar bembelimen bembelimen - change - 3 Jul 2024
Labels Removed: NPM Resource Changed
avatar bembelimen bembelimen - change - 3 Jul 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-07-03 13:27:36
Closed_By bembelimen
avatar bembelimen
bembelimen - comment - 3 Jul 2024

Thanks.

@Hackwar could you do a PR to deprecate all this inline stuff and think about a proper implementation?

Add a Comment

Login with GitHub to post a comment