PR Review ?

PR Code Suggestions ✨

-public function onExtensionAfterInstall(AbstractExtensionEvent $event): void
+public function onExtensionAfterInstall(AfterInstallEvent $event): void
 

-if ($event->getEid()) {
+if ($event->getEid() && $this->fileCreator !== null) {
     // Update / Create new map
     $this->fileCreator->create();
 }
 

-if ($eid && $removed) {
+if ($eid && $removed && $this->installer !== null) {
     $this->removeUpdateSites($eid);
 }
 

-// @TODO: The event dispatched twice, here and at the end of current method. One of it should be removed.
-$app->getDispatcher()->dispatch('onJoomlaAfterUpdate', new AfterJoomlaUpdateEvent('onJoomlaAfterUpdate'));
+// Trigger event after joomla update.
+$app->getDispatcher()->dispatch('onJoomlaAfterUpdate', new AfterJoomlaUpdateEvent('onJoomlaAfterUpdate', [
+    'oldVersion' => $oldVersion ?: '',
+]));
 

 return [
-    'onExtensionBeforeUpdate'    => 'onExtensionBeforeUpdate',
-    'onExtensionAfterUpdate'     => 'onExtensionAfterUpdate',
-    'onJoomlaBeforeUpdate'       => 'onJoomlaBeforeUpdate',
-    'onJoomlaAfterUpdate'        => 'onJoomlaAfterUpdate',
-    'onInstallerBeforeInstaller' => 'onInstallerBeforeInstaller',
-    'onInstallerAfterInstaller'  => 'onInstallerAfterInstaller',
+    self::EVENT_EXTENSION_BEFORE_UPDATE    => 'onExtensionBeforeUpdate',
+    self::EVENT_EXTENSION_AFTER_UPDATE     => 'onExtensionAfterUpdate',
+    self::EVENT_JOOMLA_BEFORE_UPDATE       => 'onJoomlaBeforeUpdate',
+    self::EVENT_JOOMLA_AFTER_UPDATE        => 'onJoomlaAfterUpdate',
+    self::EVENT_INSTALLER_BEFORE_INSTALLER => 'onInstallerBeforeInstaller',
+    self::EVENT_INSTALLER_AFTER_INSTALLER  => 'onInstallerAfterInstaller',
 ];
 

 class BeforeJoomlaUpdateEvent extends AbstractJoomlaUpdateEvent
 {
+    public function __construct()
+    {
+        // Initialize properties or perform setup
+        parent::__construct();
+    }
 }
 

I have tested this item ✅ successfully on 2461713

Installed multiple extensions (and updated 1 of them and uninstalled them - just in case) successfully..

I have tested this item ✅ successfully on 2461713

Installation extensions still works after applying patch. Site also still works.

@exlemor @crommie Have you also tested that Joomla Updates work as before? The testing instructions tell to do so. It could be done e.g. by applying the patch to a 5.2-dev and then updating to the patched package created by drone.

? no. Can I do that on a PBF server site?

? no. Can I do that on a PBF server site?

@crommie I think yes. They can later revert it to the initial state, as far as I know.

I have not tested this item.

Install and uninstall of Extension works as expected.

I have tested this item ✅ successfully on 2461713

Install and uninstall of Extension works as expected.

? no. Can I do that on a PBF server site?

@crommie I think yes. They can later revert it to the initial state, as far as I know.

Just checking: does "reinstall core files" use the same process or is that entirely different?

? no. Can I do that on a PBF server site?

@crommie I think yes. They can later revert it to the initial state, as far as I know.

Just checking: does "reinstall core files" use the same process or is that entirely different?

@crommie Reinstall core is ok, that also uses the Joomla Update component as if it was an update.

P.S.: But you should be on the custom update URL created by Drone for this PR so the PR is still applied after the update.

Hi @richard67,

Based on your comment, I tested the Joomla Update process for this PR and it worked :)

Thanks.

@exlemor Could you submit again your test result? @obuisard has updated the branch but not restored the previous human tests in the issue tracker, so the test count got reset.

Sure @richard67 , I will submit it again.

Olivier just told me he didn't have rights to restore the human tests. ;(

I have tested this item ✅ successfully on dcf15b1

I have tested this item successfully

Installed multiple extensions (and updated 1 of them and uninstalled them - just in case) successfully..
I also tested the Joomla Update process.

I have tested this item ✅ successfully on dcf15b1

RTC

Thank you for this contribution @Fedik.