[#43611] - [5.3] [Events] Use event classes for custom fields plugins
- Fixed in Code Base
- 10 Oct 2024
- Medium
- Build: 5.2-dev
- # 43611
- Diff
- Fedik:plg-event-media-fields
User tests: Successful: Unsuccessful:
Summary of Changes
Update fields plugins to use SubscriberInterface and event classes.
Testing Instructions
Create/edit custom fields, all should work as before.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: joomla/Manual#177
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
Feature
PR-5.2-dev
|
||
I have tested this item ✅ successfully on 6295367
with new installation with 5.1 dev and 5.2 dev
Have I tested
New Group
New Subfild
New calendar
New Articles
Filled in the new fields
Saved
Checked logs
everything ok
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43611.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43611.
| Labels |
Added:
RTC
|
||
I'm not convinced that the subform field works and since none of the testers claimed to have tested that, I'd like to wait with merging.
@Hackwar - I just retested it with the subform field... Here is a screenshot:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43611.
Here it is (had to use GitHub, Joomla Issue Tracker wouldn't let me add the image :/
The subform field appears at the top and the regular custom field on the bottom.
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-10 18:57:53 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
PR-5.3-dev
Removed: PR-5.2-dev |
||
Thanks!
I have tested this item ✅ successfully on 6295367
I created a Textarea field, a radio button field, Media (image) and it worked perfectly.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43611.