branch updated to retrigger drone which is failing on unrelated items

branch updated to retrigger drone which is failing on unrelated items

@brianteeman Not unrelated. See my review comment on the postgresql/base.sql file.

@brianteeman It needs to add the new module to the extensions helper to this section here https://github.com/joomla/joomla-cms/blob/5.2-dev/libraries/src/Extension/ExtensionHelper.php#L133-L157 , with respect to alphabetical ordering within that section.

I think, there is something missing, you call the layout '_items' here:
<?php require ModuleHelper::getLayoutPath('mod_content', $params->get('layout', 'default') . '_items'); ?>
but there is not such file in the module

Did you try it?

Did you look at the layouts in other modules and how they are called?

Yes, I tried it. List only works. When I try the other options I get a fatal error

The module mod_articles_category has a similar layout call, but there is a default_items.php file in the tmpl folder
<?php require ModuleHelper::getLayoutPath('mod_articles_category', $params->get('layout', 'default') . '_items'); ?>

sorry I was replying from my phone. a file was missing from the commit.

I have tested this item ✅ successfully on 3a75ffd

I have tested this item ✅ successfully on 3a75ffd

RTC

With the correct combination one can get almost the same as with the current modules. Only for 2 I was not able to do so:

• Articles - Archived -> Filter Archived Artcles only
• Articles - Categories
• Articles - Category -> Select category, play with parameter, use filter, group them, etc.
• Articles - Latest -> Change ordering to newest first
• Articles - Most Read -> Change ordering to hits
• Articles - Newsflash -> Select category, play with parameter, use filter, group them, etc.
• Articles - Related

It is possible to select a header level, but that is not being used in the layout

1. Articles Related & Articles Categories - I deliberately didnt include these ones as they're pretty useless and as this new module is an addition instead of a replacement I didnt see the point.

2. item_heading is a weird one. Will need to look into it further but a quick check shows it is present and used in mod_articles_news and is present and NOT used in mod_article_categories

1. Thank you for the explanation. I use the two modules sometimes, Articles Related more, although I find it weird that you need to set keywords instead of tags, but that is another story ;-)
2. It is indeed weird. Maybe we can add "none" as option for cases, where one want to have only a list of titles without a specific heading

There may be other params that are not presented correctly. More eyes => find more bugs

Back to pending due to previous comments which suggest further improvements and completions.

Thank you @brianteeman for this module! And everybody else for the feedback!

Regarding the currently missing “Articles - Categories” and “Articles - Related” views:
We discussed about that in CMS Maintenance Team and decided that we do not need those:

• The “Articles - Categories” shows Categories and should not be part of the new module.
• The “Articles - Related” uses some outdated fields which might be removed in Joomla 6.

We would like to have a couple of improvements before we can add it to the core:

• Because the module does only articles stuff, we would like to re-title the module to mod_articles.
• We would also like to have item_heading implemented.
• And we would like to have more layouts so that the users can choose one without having to do a template override.

@brianteeman, do you have time and could you make those improvements?
If not, no problem. Then I can ask someone else to further improve your work.
Thanks!

I have the time to work on this when you do me the same courtesy and respond to my requests directly to you that you simply ignore.

We had a discussion in the maintainer channel about that, The RTC had to be reverted,.
Testers must know why their tests are rejected.

@pe7er I think @brianteeman refers to #43625 with his comment #43610 (comment) .

I have the time to work on this when you do me the same courtesy and respond to my requests directly to you that you simply ignore.

I'm sorry if you feel ignored with another PR as that wasn't my intention.

I feel your reply as being passive aggressive. When I volunteered for my role as Joomla 5.2 Release Manager, I did not sign up for this kind of negativity. I do not accept this kind of behavior from anyone.
I have just added you to my .joomlaignore list.

@chmst agreed. As Richard realised I was talking about something else. I will just close this. Don't need or appreciate the comments. Seems that standards of behaviour don't apply to release leads. This is not the first time.