[#43592] - [5.2] Improve button toolbar for templates
- Closed
- 24 Aug 2024
- Medium
- Build: 4.4-dev
- # 43592
- Diff
- chmst:templatestyle-close-delete
User tests: Successful: Unsuccessful:
Pull Request for Issue #43212 .
Summary of Changes
Several users mentioned confusion i the com_templates toolbar, caused by the delete-file and close-file button.
This is an attempt to provide a solution with as few changes as possible.
Some buttons are used in the whole system and cannot be changed for this view, so we have not many options for changes here.
I suggest
-
change the text on the "close file" button to "close". Because this button does not only close the file but it closes the screen and redirects back, for users it does not matter if there is another action in the code.
-
Move the "Close" Button" directly after the action buttons, before the file management buttons.
-
Use the trash icon on the "file delete" button. We had many discussions about that - In Joomla the trash button means "trashed" => state = -2 not "deleted permanently", but when we think as a user not as a developer, the icon is completely clear here.
I improved the code a little bit by removing an unused variable and with switch instead of elseif.
Testing Instructions
Play around in templates and template styles, make child templates, manage files.
Whatever you want to do with your template should have a comprehensive and complete toolbar, in most cases the same as before.
Actual result BEFORE applying this Pull Request
see #43212.
delete button and close-file button.
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates Language & Strings |
| Labels |
Added:
Language Change
Backend Template
UI/UX
PR-4.4-dev
|
||
Cannot find a use case with "archive", but it has also the template.cancel task.
@brianteeman I could do that, it needs a new button in button layouts.
Fun fact: only the "close" button does something - it closes the open file before exit. In all other cases, it is a cancel action and does nothing than exit.
Is this better?
Hmm, "exit" would scare me because it would make me think it logs me off the administrator completely .. but maybe it's only me thinking like that.
@brianteeman I don't agree with you. We have "Save & Close". So why shouldn't we use "Close"? Otherwise, we should think about "Save & Exit".
You missed the point.
@dautrich We have the buttons
Save -> save changes in the file and don't quit
Save and Close -> save changes in the file and quit
Close -> do NOT save changes and quit.
We hat this discussion already in a former version and my suggestion for the exit icon was refused with the same argument as @richard67 mentioned in his comment.
Save / Save and Close on green color.
Close may be blue or leave it green.
Delete File on red color (at the end of the buttons).
Before PR:
After PR, button moved and icon is black.
The color of the "make a child" button is black in Version 4.4, with or without PR.
Seems that this was changed in J5.
I made this PR on 4.4 - but am ready to upgrade for another version.
About the sequence: We can change it. My thoughts were: Seeing a preview of the template is for all, without special permission. And it is logical that a user first wants to see the preview, then decides if he want a child template or better look for another template.
It is missing btn-primary class. This is not the case without this PR.
I have tested this item ✅ successfully on 16a507e
Works well, thank you for the work you put in
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43592.
I have tested this item ✅ successfully on 16a507e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43592.
This PR needs to be rebased to 5.2-dev. Not sure if I should do that now as the 5.2-dev branch is 2 commits behind 4.4-dev. Will try and if it doesn't work revert.
Thank you all testers for testing. Unfortunately this cannot go into 4.4 and has conflicts with 5,2. and cannot be rebased.
I will resolve conflicts and make it for 5.2 and tests must be repeated.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-24 15:26:10 |
| Closed_By | ⇒ | chmst |
just a thought about enhancing this further. Before this we have both a "close" and a "close file" depending on the context. They do different things. Close returns to the template manager, close file - closes the open file.
How about changing "close" to "exit" with the exit door icon. This way we do not have two buttons with the same icon and name that do different things