[#43588] - Check if the identity is available when injecting into the local adapter
- Fixed in Code Base
- 11 Jun 2024
- Medium
- Build: 5.1-dev
- # 43588
- Diff
- Digital-Peak:local/identity
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
When the local adapter is loaded through a console application it crashes.
Testing Instructions
Add the following line to the file /plugins/task/sessiongc/src/Extension/SessionGC.php inside the sessionGC function after line number 104:
$this->getApplication()->bootComponent('media')->getMVCFactory()->createmodel('Media', 'Administrator')->getProviders();
Then run the following commend in the console:
php cli/joomla.php scheduler:run -i 2
If the session GC task has a different id than 2, adapt the command accordingly.
Actual result BEFORE applying this Pull Request
The command fails with the current message:
Joomla\Plugin\Filesystem\Local\Adapter\LocalAdapter::setCurrentUser(): Argument #1 ($currentUser) must be of type Joomla\CMS\User\User, null given, called in /plugins/filesystem/local/src/Extension/Local.php on line 138
Expected result AFTER applying this Pull Request
Task runs trough.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item ✅ successfully on 0235bdf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43588.
sorry I can't test it as I cannot replicate the reported error
Did you add the mentioned line from the test instructions? If yes, can you add a print_r of the result from the new code?
Did you add the mentioned line from the test instructions? If yes, can you add a print_r of the result from the new code?
No I did not as I assumed that the error was always present. Sorry if that was my misunderstanding.
I have tested this item ✅ successfully on 0235bdf
tested successfully according to instructions.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43588.
| Status | Pending | ⇒ | Ready to Commit |
r2c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43588.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-06-11 10:58:47 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
RTC
bug
PR-5.1-dev
|
||
Thanks!
Fine, testet, it works on our live site.