[#43411] - [5.2] TinyMCe insert content
- Fixed in Code Base
- 7 May 2024
- Medium
- Build: 5.2-dev
- # 43411
- Diff
- brianteeman:insert_template
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
This changes the button text used when selecting a content template from "Save" to "Insert".
No additional changes are required for this to be translated as "Insert" is already translated.
(This PR was created at the request of "Daniel C K Tan" on facebook.
Testing Instructions
If you dont already have content templates set up and working for tinymce go to the plugin settings for tinymce and setup the correct folder
Then create a .txt file in that folder. (As this is just to test the UI the file can be empty)
Finaly in an article select the content template icon from the toolbar
And in the dialog that opens observe the text of the buttons.
Then apply this PR and retest. As it is a js change either apply the pr and then run npm i or use the prebuilt joomla package that can be found at the bottom of this page at the download link
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
I have tested this item ✅ successfully on 8dd3109
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43411.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43411.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-07 11:34:09 |
| Closed_By | ⇒ | pe7er |
Thanks @brianteeman !
I have tested this item ✅ successfully on 8dd3109
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43411.