[#43325] - [5.1][bug] Media manager misbehaves on files with capitalized extensions
- Closed
- 24 Apr 2024
- Medium
- Build: 5.1-dev
- # 43325
- Diff
- dgrammatiko:5.1-dev_mm-bug
User tests: Successful: Unsuccessful:
Pull Request for Issue #43315 .
Summary of Changes
- Fix the logic
Testing Instructions
Note that you have to copy the file, Media Manager always normalizes extensions to lowercase!!!
- Copy a file with a capitalized extension
- Try to edit -> rotate -> save
Actual result BEFORE applying this Pull Request
File is not saved
Expected result AFTER applying this Pull Request
File is saved
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Libraries Front End Plugins |
I have tested this item ✅ successfully on e42d7e7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43325.
Tested resize and rotate unsuccessfully with a file named DSC_0008.JPG
Buttons "Save" and "Save & Close" seemed to work, but afterward the image was unchanged.
I have tested this item ? unsuccessfully on e42d7e7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43325.
Please apply to crop.
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
@dgrammatiko
I tested with patchtester, but I can repeat my test with the prebuilt package.
Just for my understanding: Why does testing this PR with patchtester not work? And how can I recognize such a test? Is there a special flag?
I have tested this item ✅ successfully on 1c79063
I tested with the prebuilt package (now). Took the same picture as before. Cropped, saved, resized, saved, rotated, saved and closed. Saw modified picture in media manager.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43325.
I have tested this item ✅ successfully on 1c79063
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43325.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43325.
@laoneo @LadySolveig do you want this against 5.x or 4.4.x? The issue exists in both branches and files seems to be identical (although the reported issue was for 5.x)...
Hi @dgrammatiko, I had initially created #43220 which is similar / partially around the same topic and I was recommended to base it for 4.4.x (and I confirmed the issues are both in 4.4.x and 5.x) since it would be 'up-patched' (or whatever the technical term).
If you do it against 4.4, then it must be retested and this one closed. For me it is ok to leave it in 5 but when you feel in the mood to backport to 4, then this one should be closed as it will be upmerged anyway.
I'll open a new one for 4.4, let me know if this should be closed or could be merged (skipping the upmerge)
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-24 07:51:36 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
RTC
|
||
closing since we have a pr for 4.4
tested crop, resize and rotate successfully with an image named potato.JPG