RTC NPM Resource Changed bug PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
18 Apr 2024

Pull Request for Issue #32934 .

Summary of Changes

Same as the 4.4-dev PR #43192 , but this here is for 5.1-dev.

As the modified file has been refactored in the 5.1-dev branch with PR #42784 , the change from PR #43192 cannot be merged up from 4.4-dev into 5.1-dev as it is.

Therefore I've created this PR here which does the same change as PR #43192 but at a different place due to the refactoring.

Testing Instructions

See #43192 :

  1. Create a second menu module in the administrator, assign it to the menu position and select the "Joomla Main Menu" preset for the module.
  2. Click on the toggle button to close the sidebar.
  3. Click on the "Content" menu item in the second module.

Actual result BEFORE applying this Pull Request

The sidebar stays closed.

Expected result AFTER applying this Pull Request

The sidebar opens, like for the menu entries in the first menu module.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 18 Apr 2024
avatar richard67 richard67 - change - 18 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2024
Category JavaScript Repository NPM Change
avatar richard67 richard67 - change - 20 Apr 2024
The description was changed
avatar richard67 richard67 - edited - 20 Apr 2024
avatar exlemor exlemor - test_item - 20 Apr 2024 - Tested successfully
avatar exlemor
exlemor - comment - 20 Apr 2024

I have tested this item ✅ successfully on 5c58018

Hi Richard,

I was able to test this successfully. :)

Thanks for your hard work.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43308.
avatar fgsw fgsw - test_item - 20 Apr 2024 - Tested successfully
avatar fgsw
fgsw - comment - 20 Apr 2024

I have tested this item ✅ successfully on 5c58018


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43308.

avatar Quy Quy - change - 20 Apr 2024
Status Pending Ready to Commit
Labels Added: NPM Resource Changed bug PR-5.1-dev
avatar Quy
Quy - comment - 20 Apr 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43308.

avatar bembelimen bembelimen - change - 11 May 2024
Labels Added: RTC
avatar bembelimen bembelimen - change - 11 May 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-05-11 19:32:04
Closed_By bembelimen
avatar bembelimen bembelimen - close - 11 May 2024
avatar bembelimen bembelimen - merge - 11 May 2024
avatar bembelimen
bembelimen - comment - 11 May 2024

Thx

Add a Comment

Login with GitHub to post a comment