[#43296] - [5.2] Add missing Toggle inline help button to plugin modal / dialog
- Fixed in Code Base
- 21 May 2024
- Medium
- Build: 5.1-dev
- # 43296
- Diff
- Ruud68:modal-inline-help
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #43289 (comment) .
Summary of Changes
plugin modal was missing Toggle inline help button
Testing Instructions
a. add a description to a field in the file ./plugins/system/redirect/redirect.xml
e.g. to this field:
<field
name="collect_urls"
type="radio"
layout="joomla.form.field.radio.switcher"
label="PLG_SYSTEM_REDIRECT_FIELD_COLLECT_URLS_LABEL"
description="PLG_SYSTEM_REDIRECT_FIELD_COLLECT_URLS_LABEL"
default="1"
filter="integer"
>
<option value="0">JDISABLED</option>
<option value="1">JENABLED</option>
</field>
(line 6: description = has been added)
-
disable the system redirect plugin
-
goto com_redirect
-
in the alert telling you that the system redirect plugin is disabled, click on the link > the plugin will open in a modal
Actual result BEFORE applying this Pull Request
The modal had three buttons: Save, Save & Close and Close
Expected result AFTER applying this Pull Request
The modal has 4 buttons: Save, Save & Close, Close and Toggle inline help
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_plugins |
| Title |
|
||||||
I have tested this item ? unsuccessfully on 9ed546c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296.
Are you sure that is a good test instruction. That plugin doesnt show the toggle inline help button in a normal view either
I have tested this item ✅ successfully on 9ed546c
after testing with a plugin that does have inline help I am changing my test result to successfull.
Please provide better testing instructions!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296.
@brianteeman How did you test? Which plugin?
i edited the code so that I could test the sef plugin
Sorry everybody, instructions updated. Toggle inline Help button is hidden when there are no descriptions in the XML file. I have added a step to add a description to the redirect plugin.
I also added visuals for what and where to click / what it will show.
Hope this makes it clear. Sorry for the confusion!
I have tested this item ✅ successfully on 9ed546c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296.
Thanks for testing everybody! Appreciate you taking the time for it.
Thank you for this great idea!
As it is not yet available in other modals either, such as article new/edit or contact new/edit, I see it as a new feature. Since we only deal with bug fixes in 5.1, I will pass it on to the 5.2 team @pe7er @woluweb
Could you imagine adding it to the other components as well @Ruud68 ? That would be wonderful!
| Labels |
Added:
RTC
bug
|
||
| Title |
|
||||||
| Category | Administration com_plugins | ⇒ | Unit Tests Administration com_banners com_checkin com_contact com_finder com_installer com_messages com_newsfeeds com_plugins com_redirect com_users Language & Strings Modules JavaScript Repository NPM Change Installation |
| Labels |
Added:
Feature
Unit/System Tests
Language Change
NPM Resource Changed
PR-5.2-dev
Removed: bug PR-5.1-dev |
||
| Category | Administration com_plugins Unit Tests com_banners com_checkin com_contact com_finder com_installer com_messages com_newsfeeds com_redirect com_users Language & Strings Modules JavaScript Repository NPM Change Installation | ⇒ | Administration com_plugins |
We have also dialogs for adding and editing contacts, articles and it would be nice if we could have it here also.
Not sure if I am missing something, where this could also be useful.
Sorry I must have confused this PR with another one as I was sure I had seen changed across all modals
| Labels |
Removed:
Unit/System Tests
Language Change
NPM Resource Changed
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-21 09:28:38 |
| Closed_By | ⇒ | pe7er |
I have tested this item ? unsuccessfully on 9ed546c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43296.