[#43295] - [5.1] Proper support for avif/webp images
- Fixed in Code Base
- 14 May 2024
- Medium
- Build: 5.1-dev
- # 43295
- Diff
- dgrammatiko:image
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- add missing avif support in the
Imageclass - The resize plugin cannot create an image from string for AVIF files (someone needs to open an issue to php-src for this)
- both webp and avif cannot be supported for editing because browsers are inconsistent atm on the
canvas.toDataURL()
spec: toDataURL
Testing Instructions
-
Either run
npm Ior use the package from the PR -
extract and upload the files Archive.zip
-
Delete/rename the files
-
Delete the files. Edit the Media Action plugin resize with some values (ie 800 and 500) and check that the images on upload are getting resized.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change Libraries Front End Plugins |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
I have tested this item ✅ successfully on 6f7b7cb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43295.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43295.
| Labels |
Added:
RTC
|
||
Can we remove the RTC. Turns out that PHP docs were wrong php/php-src#14010
Please test again with:
- Delete the files. Edit the Media Action plugin resize with some values (ie 800 and 500) and check that the images on upload are getting resized.
I have tested this item ✅ successfully on 84874f6
?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43295.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending. @Quy Could you test again? Thanks in advance.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43295.
It was commented elsewhere that this PR would also resolve an issue with files named JPG as opposed to jpg.
Sorry to say this pr makes no difference
I have tested this item ✅ successfully on 84874f6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43295.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43295.
This pull request has been automatically rebased to 5.2-dev.
@HLeithner why did you moved this one to 5.2? This is a bug fix nothing new here...
I only had quick look and just classified it as feature since nobody else looked at it and added a label. If I'm wrong no problem can be changed back as long as nobody update the branch.
AVIF support was added with #41381 but George missed some parts. This PR just adds them, it doesn't have to wait for 6 months
Edit: actually it fixes the issue reported in the introductory PR: #41381 (comment) where you also responded: #41381 (comment)
switched back to 5.1 thanks
| Labels |
Added:
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-14 06:52:04 |
| Closed_By | ⇒ | bembelimen |
Thx
I have tested this item ✅ successfully on 6f7b7cb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43295.