[#43260] - [5.2] Added link class selection to TinyMCE dialog
- Fixed in Code Base
- 30 Apr 2024
- Medium
- Build: 5.1-dev
- # 43260
- Diff
- RickR2H:tinymce-link-classes
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Add a class selector to the "create link" dialog. The selected class will be added to the link. This can be very useful in styling links on the website. Adding Bootstrap button classes will convert the link to a button.
Testing Instructions
- Go to the tinyMCE configuration and op the "Advanced tab"
- Add some classes to use in the dropdown
- Open an article and create a link. At the bottom the configured classes can be selected.
Actual result BEFORE applying this Pull Request
Adding classed only possible in the source code editor.
Expected result AFTER applying this Pull Request
Classes can be selected in the link dialog.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org: (will be created after merging the PR)
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
| Labels |
Added:
Language Change
PR-5.1-dev
|
||
works great. I never would have found it on the advanced tab
I could move it to the first "Plugin" tab? Would that be a better option?
works great. I never would have found it on the advanced tab
I could move it to the first "Plugin" tab? Would that be a better option?
I would prefer that. It is where I added all the other tinymce customisations in the past
@brianteeman I added it to the first tab at the bottom. I also removed the description of the single fields and added an overall description.
great - please update the description and screenshots in the original post to match
I have tested this item ✅ successfully on 0f4bbcb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43260.
I have tested this item ✅ successfully on 96ee302
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43260.
@brianteeman could you please do one more test? Code is fine now...
| Labels |
Added:
PR-5.2-dev
Removed: PR-5.1-dev |
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43260.
Restored tests as latest changes are cs only.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43260.
HLeithner
- | Title |
|
||||||
| Labels |
Added:
Feature
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-30 14:53:49 |
| Closed_By | ⇒ | pe7er |
works great. I never would have found it on the advanced tab