RTC bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
11 Apr 2024

Summary of Changes

When using Cron expressions in a task, then they are always executed in UTC timezone. This leads to an issue when the cron ob should run on a specific time on the day and the Joomla site is in a timezone where the there are DST changes. This pr calculates the next run date according to the timezone of Joomla and displays the next execution date in the same time when editing the task (it is the same time as in the tasks list then).

Testing Instructions

  • Define a timezone in Joomla, other than UTC
  • Create a new sleep task and define a cron expression like
    image
  • Open the execution history tab

Actual result BEFORE applying this Pull Request

It shows the UTC time as next execution date.

Expected result AFTER applying this Pull Request

It shows the correct time as next execution date.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 11 Apr 2024
avatar laoneo laoneo - change - 11 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2024
Category Administration
avatar hytsch
hytsch - comment - 11 Apr 2024

checked, works fine, thanks :)

avatar fgsw fgsw - test_item - 12 Apr 2024 - Tested successfully
avatar fgsw
fgsw - comment - 12 Apr 2024

I have tested this item ✅ successfully on 2a56945


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43259.

avatar Quy Quy - alter_testresult - 12 Apr 2024 - hytsch: Tested successfully
avatar Quy Quy - change - 12 Apr 2024
Status Pending Ready to Commit
Labels Added: PR-4.4-dev
avatar Quy
Quy - comment - 12 Apr 2024

@laoneo Please fix phpcs. Thanks.

73455a5 15 Apr 2024 avatar laoneo cs
avatar HLeithner HLeithner - change - 24 Apr 2024
Title
Determine the next task run date with the timezone of the site
[4.4] Determine the next task run date with the timezone of the site
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar MacJoom MacJoom - change - 26 Apr 2024
Labels Added: RTC bug
avatar MacJoom MacJoom - change - 26 Apr 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-04-26 18:26:11
Closed_By MacJoom
avatar MacJoom MacJoom - close - 26 Apr 2024
avatar MacJoom MacJoom - merge - 26 Apr 2024
avatar MacJoom
MacJoom - comment - 26 Apr 2024

Thank you!

Add a Comment

Login with GitHub to post a comment