[#43247] - [5.2] remove margin-bottom on .btn styling to prevent nasty offset
- Fixed in Code Base
- 11 Jul 2024
- Medium
- Build: 5.1-dev
- # 43247
- Diff
- hans2103:feature/5.1-btn-toolbar
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR will remove the following piece of SCSS and uses proper Bootstrap classNames to achieve the same goal.
PR #32697 introduced a margin-bottom of .25em on all buttons.
A fix made by @brianteeman prevented this to happen on buttons in an input-group.
Both are not needed when using proper Bootstrap classNames on the wrapping element.
Testing Instructions
- Joomla 5.1 with sample data installed.
- Compile SCSS
- Head over to page Typography and reduce the viewport. On mobile the elements with className
.btnare stacked with a proper gap between. - Login on frontend and click an item to edit. On mobile the elements with className
.btnare stacked with a proper gap between. - Go to a random page to invoke a 404. Inspect the button with home icon and text "Home page". On mobile this button has no obsolete margin-bottom anymore. And all elements with className
.btndon't have a obsolete margin-bottom anymore.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Comment
Even Bootstrap core has no margins around buttons. See screenshot below where I have disabled the DOCS styling.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Repository NPM Change Front End com_config com_contact com_content |
| Labels |
Added:
Language Change
NPM Resource Changed
PR-5.1-dev
|
||
Thanks
This pull request has been automatically rebased to 5.2-dev.
| Labels |
Added:
Feature
|
||
| Title |
|
||||||
| Labels |
Added:
PR-5.2-dev
|
||
| Labels |
Removed:
PR-5.1-dev
|
||
I have tested this item ✅ successfully on bbc2940
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43247.
I have tested this item ✅ successfully on 59254e3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43247.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43247.
| Labels |
Added:
RTC
|
||
pe7er
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-11 16:40:06 |
| Closed_By | ⇒ | pe7er |
Which was the PR I made a partial fix in? Would like to check exactly what the issue it was fixing is still fixed. Thanks