RTC Language Change PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Apr 2024

Spotted while debugging

Summary of Changes

The error message is a sentence so it must end with a period

Testing Instructions

code review

Maintainers

No idea anymore which branch this shoud go in. Feel free to move it. As long as its fixed somewhere I dont care

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 10 Apr 2024
avatar brianteeman brianteeman - change - 10 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2024
Category Administration Language & Strings
avatar wojsmol wojsmol - test_item - 10 Apr 2024 - Tested successfully
avatar wojsmol
wojsmol - comment - 10 Apr 2024

I have tested this item ✅ successfully on a495d5c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43249.

avatar chmst chmst - test_item - 10 Apr 2024 - Not tested
avatar chmst
chmst - comment - 10 Apr 2024

I have not tested this item.

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43249.

avatar chmst chmst - test_item - 10 Apr 2024 - Tested successfully
avatar chmst
chmst - comment - 10 Apr 2024

I have tested this item ✅ successfully on a495d5c

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43249.

avatar chmst
chmst - comment - 10 Apr 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43249.

avatar chmst chmst - change - 10 Apr 2024
Status Pending Ready to Commit
avatar chmst
chmst - comment - 10 Apr 2024

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43249.

avatar richard67
richard67 - comment - 14 Apr 2024

@chmst Are you sure the milestone 5.2.0 which you have set is right? Or did you want to set 5.1.1 (which doesn't exist yet)?

avatar HLeithner HLeithner - close - 24 Apr 2024
avatar HLeithner HLeithner - merge - 24 Apr 2024
avatar HLeithner HLeithner - change - 24 Apr 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-04-24 07:59:57
Closed_By HLeithner
Labels Added: RTC Language Change PR-5.1-dev
avatar brianteeman
brianteeman - comment - 24 Apr 2024

Thanks

Add a Comment

Login with GitHub to post a comment