[#43207] - [5.1] Fix the build tools
- Fixed in Code Base
- 5 Apr 2024
- Medium
- Build: 5.1-dev
- # 43207
- Diff
- dgrammatiko:5.1-dev-phpbuild
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- the JS cssversioning script needs to be aware where is the current
cmd - it needs to respect
.minfiles
Testing Instructions
Run php build/build.php and check the build/tmp/media folder that all the css files with a URL() (ie font awesome) end with something like ?3jhff
Download the package from https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43207/downloads/75243/
Extract the files
Check that the file media/templates/administrator/atum/css/vendor/fontawesome-free/fontawesome.css and media/templates/administrator/atum/css/vendor/fontawesome-free/fontawesome..min.css start with @charset "UTF-8";
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Labels |
Added:
PR-5.1-dev
|
||
I have tested this item ? unsuccessfully on 79d2df0
Still the same none charset css files
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43207.
Still the same none charset css files
My test instructions are wrong, this needs a new tagged version (ie 5.1.0-RC2) with the code of this PR. This is because of this line:
Line 272 in 896fa4b
I have no clue how this could be tested without merging and then tagging another RC...
@HLeithner any ideas?
UPD: well, I'm forcing the replacement of the build folder and it works but maybe not the best approach...
can you please revert this copy thing... if we need a tagged version then it's not a problem to test this.
I tested the version before with a tagged release and it works, so please remove the copy code and I can merge it.
Ok,
will revert the php parts later on
done
I have tested this item ? unsuccessfully on 1489989
many thanks for your work so far @dgrammatiko
running php build/build.php still generates the output without charset in the tmp source code subfolder - e.g. build/tmp/1712314537.
The generated packages for a new 5.1 release are therefore still with none charset.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43207.
@LadySolveig this is actually expected and it was requested from @HLeithner here: #43207 (comment)
The important part here is explained here: #43207 (comment)
Basically if you want to test this right now you need to manually edit the build.php file according to cb48ff9
In a real release, assuming the PR is already merged, the release leader creates a tag and publish it in the GitHub then everything would work as expected
I have tested this item ✅ successfully on 1489989
many thanks for your work so far @dgrammatiko
running php build/build.php still generates the output without charset in the tmp source code subfolder - e.g. build/tmp/1712314537.
The generated packages for a new 5.1 release are therefore still with none charset.
Thank you again for the explanation. Just tested with a new tag and all works as expected. ? ? I apologise for not reading the comments carefully enough.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43207.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-05 12:02:30 |
| Closed_By | ⇒ | LadySolveig |
Thank you so much for fixing this so quickly. @dgrammatiko
Thank you, will test it asap.