[#43192] - [4.4] Adminmenu: Toggle for duplicate menus
- Fixed in Code Base
- 27 Apr 2024
- Medium
- Build: 4.4-dev
- # 43192
- Diff
- Hackwar:4.4-adminmenu-js
User tests: Successful: Unsuccessful:
Pull Request for Issue #32934 .
Summary of Changes
When the backend menu is duplicated, the JS to toggle the sidebar doesn't work for the second menu.
Testing Instructions
- Create a second menu module in the administrator, assign it to the menu position and select the "Joomla Main Menu" preset for the module.
- Click on the toggle button to close the sidebar.
- Click on the "Content" menu item in the second module.
Actual result BEFORE applying this Pull Request
The sidebar stays closed.
Expected result AFTER applying this Pull Request
The sidebar opens, like for the menu entries in the first menu module.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-4.4-dev
|
||
I have tested this item ✅ successfully on ed76cd4
I confirm that it was a success test for me.
PHP 8.2.17, MySQL 8.0.36
CentOS v7.9.2009 STANDARD kvm cPanel v110.0.24
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43192.
I have tested this item ✅ successfully on ed76cd4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43192.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43192.
@Hackwar As @brianteeman correctly mentioned in his previous comment, this fix can't be merged up into 5.1-dev as it is because in 5.1-dev the js was refactored. It would need to make the same changes as here but in these 2 lines:
- https://github.com/joomla/joomla-cms/blob/5.1-dev/build/media_source/mod_menu/js/admin-menu.es6.js#L115
- https://github.com/joomla/joomla-cms/blob/5.1-dev/build/media_source/mod_menu/js/admin-menu.es6.js#L121
Could you make a PR for 5.1-dev, too?
It needs both, I think, this one here for 4.4-dev and another one for 5.1-dev.
Could you make a PR for 5.1-dev, too?
It needs both, I think, this one here for 4.4-dev and another one for 5.1-dev.
@Hackwar As I did not get any response to my comment, I've decided to create the 5.1-dev PR myself. Thanks for the fix here. PR for 5.1-dev is #43308 .
To all testers: Could you also test my PR #43308 for 5.1? Thanks in advance.
Tested #43308 for J5.1.x - thanks @richard67.
| Labels |
Added:
RTC
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-27 09:34:11 |
| Closed_By | ⇒ | MacJoom |
Thank you!
If you do this as per the original report by duplicating the existing module then you break accessibility as you have multiple things using the same id
but thats off topic