[#43161] - [5.1] sidebar-wrapper border
- Closed
- 3 Apr 2024
- Medium
- Build: 5.1-dev
- # 43161
- Diff
- brianteeman:sidebar-wrapper
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Removes the extra border on the sidebar that is producing a pixel shift between light and dark mode.
I can't see the need for this border buy maybe @coolcat-creations sees something I am missing and it should remain
Pull Request for Issue #43159
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
The border was added because of the Wish from release management for better contrast between content and sidebar and toolbar and content @LadySolveig
The border was added because of the Wish from release management for better contrast between content and sidebar and toolbar and content @LadySolveig
In case it could be a border only on the right?
The border was added because of the Wish from release management for better contrast between content and sidebar and toolbar and content @LadySolveig
In case it could be a border only on the right?
If I added it surrounding the sidebar it was indeed a mistake
I have tested this item ✅ successfully on fd8aaf9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43161.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43161.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-03 07:28:10 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
RTC
|
||
I have tested this item ✅ successfully on fd8aaf9
now the menu items do not move horizontally when changing from light to dark theme.
They move vertically, but I think it is related to issue fixed with #43138
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43161.