[#43160] - [5.1] Dark Mode menu select toggle colour
- Fixed in Code Base
- 27 Mar 2024
- Medium
- Build: 5.1-dev
- # 43160
- Diff
- brianteeman:43068
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
final part Pull Request for Issue #43068 .
Summary of Changes
Change the colour of the icon in the treeselect for assigning modules to pages to satisfy contrast rules
Testing Instructions
see #43068 for more details
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
I have tested this item ✅ successfully on d9bd44a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43160.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
a11y
PR-5.1-dev
Dark Mode
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43160.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-27 17:09:07 |
| Closed_By | ⇒ | LadySolveig |
Thank you @brianteeman and also for testing @viocassel @Quy
thanks
@brianteeman I commited to the 5.2 branch. I think you PR was not up-merged. That why I didn't notice it. I'll close my PR and I'll wait for the up-merge.
No your PR is needed. This was upmerged but
Did not work then (we need to improve our testing) or has another PR somewhere else changed the behaviour
I have tested this item ✅ successfully on d9bd44a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43160.