Can you please add #39102 to the to-do list?

This pull request has been automatically rebased to 5.2-dev.

@Fedik One of the issues with this script that I would like to resolve is that there are a lot of advanced customisations that can be made via js or css. Creating a UI for this would be overkill as they are typically advanced use cases.

My thought process is that the plugin can have two additional fields for the user to enter advanced jss and css.

An example might be entering the following to the js field

instance.menuInterface.increaseText = function() {

// My own way to increase text size . . .

}

My question therefore is what would be the correct way to output/use the contents of these two advanced fields.

That could work, but that a very bad idea ?

What you could try, is to add "important options" (from your point of view) to the plugin parameters.
And then move this code

And for css it can be part of user.css (or something kind of accessibility-user.css).

Before I comment on why I dont want to do it the way that you suggest can you explain why it is a bad idea. I wont learn anything otherwise.

Allowing User to insert JS in backed, is kind of the same as allowing User insert PHP in backend.
We cannot control that code, and what they put in there.
Integrate this code with existing plugin parameters will be close to impossible.

Addittionaly it can create a potential security problem.

Allowing User to insert JS in backed, is kind of the same as allowing User insert PHP in backend.

Doh - silly me

Since I started this PR upstream has completely changed (again)

It is now possible to create our own ui for the toolbar instead of the hacky solutions that were previously available

See the Custom Styling section https://ranbuch.github.io/accessibility/site/

Note: The icons from Angie will need to be adjusted if we want to use them as an icon font (doesnt support multiple colors/shades) although I guess if the latest upstream changes are used to create our own UI for the toolbar then svg could be used

Doing some tests today. The hotkeys work for me, but ctrl+alt+q (animations) in Chrome but not in Firefox
ctrl+alt+r activate the reading guide an opens something from my graphic card too, but that is something specific from my PC

yeah the hotkeys are weird. No idea what to do there

IBM Equal Access Accessibility Checker and in the Firefox Accessibility tab I get some errors / things to review... can we do something here?

As you said you didnt want to create our own ui these are both upstream issues to resolve.

i think it is probably better to use the fontawesome web asset than the icons generated by angie

My vision is fontawesome icons as default but an option for custom icons.

dont be confused with the icons for the toolbar actions and the icon for the button

Just for reference, I have submitted a PR upstream for the tabindex issue ranbuch/accessibility#87 PR ranbuch/accessibility#86

I gave up looking at this due to the complete lack of any communication from the accessibility team

@brianteeman would you mind reopening this PR? So that hopefully we can bring the new version into 5.4

It cant be re-opened as the 5.2-dev branch has been deleted here so github wont let me.

While I was working on it I discovered loads of bugs which he fixed but it really requires a rewrite of the plugin to be able to use the icons the way we want to. The implementation that ranbuch did for non-material icons is a pia

Do you want to open a new one or should I do it? Would really like to work with you on this.

I gave up looking at this due to the complete lack of any communication from the accessibility team

Do as you wish. I won't waste any more if my time on it as the accessibility team clearly are not interested

Thank you, then I am pleased to build on the work you have already done.