RTC bug PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
24 Mar 2024

Summary of Changes

When an update of Joomla failed and the joomla-welcome guided tour wasn't added to the database, a big warning is displayed at the top of the backend dashboard. This PR adds another check to make sure we loaded anything in the first place before accessing it.

Testing Instructions

  1. Install Joomla
  2. Delete the joomla-welcome from #__guidedtours
  3. Login to the backend.

Actual result BEFORE applying this Pull Request

Big warning at the top of the screen.

Expected result AFTER applying this Pull Request

No warning.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 24 Mar 2024
avatar Hackwar Hackwar - change - 24 Mar 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2024
Category Front End Plugins
avatar obuisard obuisard - test_item - 24 Mar 2024 - Tested successfully
avatar obuisard
obuisard - comment - 24 Mar 2024

I have tested this item ✅ successfully on 8036900


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43139.

avatar Quy Quy - test_item - 24 Mar 2024 - Tested successfully
avatar Quy
Quy - comment - 24 Mar 2024

I have tested this item ✅ successfully on 8036900


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43139.

avatar Quy Quy - change - 24 Mar 2024
Status Pending Ready to Commit
Labels Added: bug PR-5.1-dev
avatar Quy
Quy - comment - 24 Mar 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43139.

avatar Quy Quy - change - 24 Mar 2024
Labels Added: RTC
avatar LadySolveig LadySolveig - close - 27 Mar 2024
avatar LadySolveig LadySolveig - merge - 27 Mar 2024
avatar LadySolveig LadySolveig - change - 27 Mar 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-27 17:48:50
Closed_By LadySolveig
avatar LadySolveig
LadySolveig - comment - 27 Mar 2024

Thank you @Hackwar and also for testing @obuisard and @Quy

Add a Comment

Login with GitHub to post a comment