RTC NPM Resource Changed PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Mar 2024

Pull Request for Issue #43029 .

Summary of Changes

remove additional border on header buttons in dark mode
this prevents the layout shift between light/dark templates

Actual result BEFORE applying this Pull Request

beforeshift

Expected result AFTER applying this Pull Request

shift

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 24 Mar 2024
avatar brianteeman brianteeman - change - 24 Mar 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2024
Category Repository NPM Change
avatar exlemor
exlemor - comment - 24 Mar 2024

Thanks for the fix everyone (hug).

avatar Quy Quy - test_item - 24 Mar 2024 - Tested successfully
avatar Quy
Quy - comment - 24 Mar 2024

I have tested this item ✅ successfully on 8e7b8c7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43138.

avatar viocassel viocassel - test_item - 24 Mar 2024 - Tested successfully
avatar viocassel
viocassel - comment - 24 Mar 2024

I have tested this item ✅ successfully on 8e7b8c7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43138.

avatar Quy Quy - change - 24 Mar 2024
Status Pending Ready to Commit
Labels Added: NPM Resource Changed PR-5.1-dev
avatar Quy
Quy - comment - 24 Mar 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43138.

avatar LadySolveig LadySolveig - change - 27 Mar 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-27 17:45:58
Closed_By LadySolveig
Labels Added: RTC
avatar LadySolveig LadySolveig - close - 27 Mar 2024
avatar LadySolveig LadySolveig - merge - 27 Mar 2024
avatar LadySolveig
LadySolveig - comment - 27 Mar 2024

Thank you @brianteeman and also for testing @Quy @viocassel

avatar brianteeman
brianteeman - comment - 27 Mar 2024

thanks

Add a Comment

Login with GitHub to post a comment