Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#43129] - [5.1] Fix for legacy editor-xtd plugins with array of buttons

RTC bug PR-5.0-dev PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
23 Mar 2024

Pull Request for Issue #43128 .

Summary of Changes

Fix compatibility with legacy editor-xtd plugins, which return multiple buttons.

Testing Instructions

Edit

joomla-cms/plugins/editors-xtd/contact/src/Extension/Contact.php

Line 46 in ef33d44

public function onDisplay($name)

And replace whole method with:

public function onDisplay($name)
{
  return [
    new CMSObject([
        'action'  => 'insert',
        'icon'    => 'foobar',
        'text'    => 'Beer',
        'options' => ['content' => '? ']
    ]),
    new CMSObject([
        'action'  => 'insert',
        'icon'    => 'foobar',
        'text'    => 'Cat',
        'options' => ['content' => '? ']
    ]),
  ];
}

Go to content editing. And check for this button.

Actual result BEFORE applying this Pull Request

Only Cat button is shown.

Expected result AFTER applying this Pull Request

Both buttons is shown.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 23 Mar 2024
avatar Fedik Fedik - change - 23 Mar 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Mar 2024
Category ⇒ Libraries
avatar Tazzios Tazzios - test_item - 23 Mar 2024 - Tested successfully
avatar Tazzios
Tazzios - comment - 23 Mar 2024

I have tested this item ✅ successfully on 07ebef5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43129.

avatar viocassel viocassel - test_item - 23 Mar 2024 - Tested successfully
avatar viocassel
viocassel - comment - 23 Mar 2024

I have tested this item ✅ successfully on 07ebef5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43129.

avatar Quy Quy - change - 23 Mar 2024
Status Pending ⇒ Ready to Commit
Labels Added: bug PR-5.0-dev
avatar Quy
Quy - comment - 23 Mar 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43129.

avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.1-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
…
[5.0] Fix for legacy editor-xtd plugins with array of buttons
[5.1] Fix for legacy editor-xtd plugins with array of buttons
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar LadySolveig LadySolveig - change - 11 May 2024
Labels Added: RTC PR-5.1-dev
avatar LadySolveig LadySolveig - close - 11 May 2024
avatar LadySolveig LadySolveig - merge - 11 May 2024
avatar LadySolveig LadySolveig - change - 11 May 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-05-11 13:15:47
Closed_By ⇒ LadySolveig
avatar LadySolveig
LadySolveig - comment - 11 May 2024

Thank you @Fedik and for testing @Tazzios and @viocassel

Add a Comment

Login with GitHub to post a comment