Joomla! Issue Tracker | Joomla! CMS #43128 - [5] editors-xtd return mutiple buttons

No Code Attached Yet bug

Closed
23 Mar 2024
Medium
Build: 4.4-dev
# 43128

Tazzios
23 Mar 2024

Is your feature request related to a problem? Please describe.

In Joomla 3 and 4 it was possible to return an array of buttons with one plugin. In joomla 5 only the last button is shown. Om not sure or this is on purpose or not so I made a feature request instead of a bug, and Im probably the only one who runs into this issue. :)

Describe the solution you'd like

Support to return an array of buttons (and also show them) instead of only one (latest) button.

Additional context

I have made a plugin which user can use to create own buttons, but in J5 it does only show the latest button of the array.
https://github.com/Tazzios/Universal-buttons/

Tazzios - open - 23 Mar 2024

joomla-cms-bot - change - 23 Mar 2024

Labels

Added: No Code Attached Yet

joomla-cms-bot - labeled - 23 Mar 2024

Tazzios - change - 23 Mar 2024

The description was changed

Tazzios - edited - 23 Mar 2024

Tazzios - change - 23 Mar 2024

The description was changed

Tazzios - edited - 23 Mar 2024

brianteeman - comment - 23 Mar 2024

see also #40472

Fedik - comment - 23 Mar 2024

In Joomla 5, also should work.
Hovewer there a new API, I suggest to update old code.
Please follow https://manual.joomla.org/docs/building-extensions/plugins/editors-xtd-plugin

For old buttons, I think there a bug in resolving legacy buttons, when there an array

joomla-cms/libraries/src/Editor/Button/ButtonsRegistry.php

Lines 132 to 148 in 4e62d6a

    
           foreach ($legacyButton as $item) { 
        
               // Extract button properties 
        
               if ($item instanceof CMSObject) { 
        
                   $props = $item->getProperties(); 
        
               } elseif ($item instanceof Registry) { 
        
                   $props = $item->toArray(); 
        
               } else { 
        
                   continue; 
        
               } 
        
               $options = !empty($props['options']) ? $props['options'] : []; 
        
               // Some very old buttons use string for options, but this does not work since Joomla 3, so we reset it here 
        
               $options = \is_array($options) ? $options : []; 
        
               unset($props['options']); 
        
               $button = new Button($plugin->name, $props, $options); 
        
               $this->add($button);

Need to check

Fedik - change - 23 Mar 2024

Labels

Added: bug

Fedik - labeled - 23 Mar 2024

Fedik - close - 23 Mar 2024

Fedik - comment - 23 Mar 2024

Please test #43129

Fedik - change - 23 Mar 2024

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2024-03-23 15:18:32
Closed_By		⇒	Fedik

Tazzios - comment - 23 Mar 2024

@Fedik That is fast! Tested your solution and it works.
Will look at the Joomla 5 documentation.

Fedik - comment - 23 Mar 2024

Please visit https://issues.joomla.org/tracker/joomla-cms/43129
and click this litle button

to set your test result

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#43128] - [5] editors-xtd return mutiple buttons

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Additional context

Add a Comment

	foreach ($legacyButton as $item) {
	// Extract button properties
	if ($item instanceof CMSObject) {
	$props = $item->getProperties();
	} elseif ($item instanceof Registry) {
	$props = $item->toArray();
	} else {
	continue;
	}

	$options = !empty($props['options']) ? $props['options'] : [];
	// Some very old buttons use string for options, but this does not work since Joomla 3, so we reset it here
	$options = \is_array($options) ? $options : [];
	unset($props['options']);

	$button = new Button($plugin->name, $props, $options);
	$this->add($button);