RTC a11y NPM Resource Changed PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
22 Mar 2024

In the module manager when you open the tree to assign a module to specific menu items it was not possible to navigate to the chevron with a keyboard to open and close the tree.

This pr ensures that you can tab to the chevron and press enter to expand or collapse the tree.

Don't moan at me for bad js as the original js was written by the person who has asked for this bug fix

PARTIAL Pull Request for Issue #43068 .

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 22 Mar 2024
avatar brianteeman brianteeman - change - 22 Mar 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2024
Category JavaScript Repository NPM Change
avatar brianteeman brianteeman - change - 22 Mar 2024
Labels Added: NPM Resource Changed PR-5.1-dev
avatar Quy Quy - test_item - 26 Mar 2024 - Tested successfully
avatar Quy
Quy - comment - 26 Mar 2024

I have tested this item ✅ successfully on 91e75fa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43125.

avatar viocassel viocassel - test_item - 26 Mar 2024 - Tested successfully
avatar viocassel
viocassel - comment - 26 Mar 2024

I have tested this item ✅ successfully on 91e75fa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43125.

avatar Quy Quy - change - 26 Mar 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Mar 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43125.

avatar wilsonge wilsonge - change - 26 Mar 2024
Labels Added: RTC a11y
avatar wilsonge wilsonge - close - 26 Mar 2024
avatar wilsonge wilsonge - merge - 26 Mar 2024
avatar wilsonge wilsonge - change - 26 Mar 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-26 23:29:56
Closed_By wilsonge
avatar brianteeman
brianteeman - comment - 27 Mar 2024

Thanks @wilsonge

avatar wilsonge
wilsonge - comment - 27 Mar 2024

Thankyou!!

Add a Comment

Login with GitHub to post a comment