please shorten the title ?

Looking at this and also on the code of hikashop (I'm actually a customer for one of my customers. ? ) I can't see anything wrong with that. I would actually rather say that the user has a seriously botched system update. My assumption is that during the update larger parts of the files were not properly replaced with the new versions, resulting in the event being triggered with the old J4 code. Can you check if the Joomla core files are actually the right ones from Joomla 5.0?

Thanks for your answer. Which file(s) should I look at ? I looked a bit around but I didn't find anything.
/libraries/src/Event/Finder/AfterDeleteEvent.php or /libraries/src/Event/CoreEventAware.php look fine.
I do see the line:
'onFinderAfterDelete' => Finder\AfterDeleteEvent::class,
in the /libraries/src/Event/CoreEventAware.php file. If I'm not correct, it should be this which is responsible to get the correct event class based on the event being trigged the old fashion way.
The trigger call in EasySocial looks fine too. It uses the old style code :
$app->triggerEvent('onAfterDeleteEvent', array(...));

The files you want to look at are everything in /administrator/components/com_finder

The error happens when he tries to delete a video in EasySocial

That the answer.

The trigger call in EasySocial looks fine too. $app->triggerEvent('onAfterDeleteEvent' ..

That not where it is trigered.
Look for EasySocial plugin wich trigger onFinderAfterDelete event.

I do not have access to their code, so cannot say more.
but the error comes from their side.

Thanks for your answer. Which file(s) should I look at ? I looked a bit around but I didn't find anything. /libraries/src/Event/Finder/AfterDeleteEvent.php or /libraries/src/Event/CoreEventAware.php look fine. I do see the line: 'onFinderAfterDelete' => Finder\AfterDeleteEvent::class, in the /libraries/src/Event/CoreEventAware.php file. If I'm not correct, it should be this which is responsible to get the correct event class based on the event being trigged the old fashion way. The trigger call in EasySocial looks fine too. It uses the old style code : $app->triggerEvent('onAfterDeleteEvent', array(...));

Hi Nicolas,

As I mentioned previously, the Joomla core file 'plugins/finder/content/src/extension/content.php' also had the same problem when they had code like yours, the 'new code', this was after upgrading it via admin from 3x to 5x. When the hikashop finder plugin was switched off, that also had the same problem. After updating the core finder plugin (content.php) I noticed the code had resorted back to the old style and worked fine.

The issue, as you know still exists with the hikashop plugin. We have reached out to EasySocial and as you can imagine they also said the issue lies with the hikashop plugin.

As you suggested above, I have updated all core files by downloading the latest Joomla version 5.0.3x and overwriting all core files, this should resolve any conflicting issues with the upgrade from 3x to 5x.

I'll ask the client to test the deletion of the videos and get back to you shortly.

@DerekBuntin : I think the answer from EasySocial is wrong. If the problem was with the HikaShop plugin, then how come you have the same issue with the content plugin of Joomla ? You should not have to modify the content plugin of Joomla.

@Fedik : I looked in the files of EasySocial and file the line:
ESDispatcher::trigger('onFinderAfterDelete', array('easysocial.videos', $this->table));
in the file administrator/components/com_easysocial/includes/video/video.php
It looks normal to me.
The trigger function is defined like this: https://i.imgur.com/3Q5HjO0.png
It looks fine to me. Any ideas ?

idk, on quick look it looks bad to me, mix of everything. They checking for J4, for code for J5.
However it need to debug a "full stack", maybe it somewhere else, something missing.

It somehow bypass our backward compatibility layer, and picking a generic Joomla\Event\Event class.

Is that ED::isJoomla4 checking on version == 4 or version > 3?

@DerekBuntin : I think the answer from EasySocial is wrong. If the problem was with the HikaShop plugin, then how come you have the same issue with the content plugin of Joomla ? You should not have to modify the content plugin of Joomla.

@Fedik : I looked in the files of EasySocial and file the line: ESDispatcher::trigger('onFinderAfterDelete', array('easysocial.videos', $this->table)); in the file administrator/components/com_easysocial/includes/video/video.php It looks normal to me. The trigger function is defined like this: https://i.imgur.com/3Q5HjO0.png It looks fine to me. Any ideas ?

After overwriting all core files we still see the issue:

plgFinderHikashopBridge::onFinderAfterDelete(): Argument #1 ($event) must be of type Joomla\CMS\Event\Finder\AfterDeleteEvent, Joomla\Event\Event given, called in /Users/derekbuntin/Websites/orajin/libraries/vendor/joomla/event/src/Dispatcher.php on line 454

1 | () | JROOT/plugins/finder/hikashop/hikashop_j5.php:52
2 | plgFinderHikashopBridge->onFinderAfterDelete() | JROOT/libraries/vendor/joomla/event/src/Dispatcher.php:454
3 | Joomla\Event\Dispatcher->dispatch() | JROOT/administrator/components/com_easysocial/includes/compatibility.php:783
4 | ESDispatcher::trigger() | JROOT/administrator/components/com_easysocial/includes/video/video.php:2674
5 | SocialVideo->delete() | JROOT/components/com_easysocial/controllers/videos.php:186
6 | EasySocialControllerVideos->delete() | JROOT/libraries/src/MVC/Controller/BaseController.php:730
7 | Joomla\CMS\MVC\Controller\BaseController->execute() | JROOT/components/com_easysocial/controllers/controller.php:67
8 | EasySocialController->execute() | JROOT/components/com_easysocial/easysocial.php:100
9 | require_once() | JROOT/libraries/src/Dispatcher/LegacyComponentDispatcher.php:71
10 | Joomla\CMS\Dispatcher\LegacyComponentDispatcher::Joomla\CMS\Dispatcher\{closure}() | JROOT/libraries/src/Dispatcher/LegacyComponentDispatcher.php:73
11 | Joomla\CMS\Dispatcher\LegacyComponentDispatcher->dispatch() | JROOT/libraries/src/Component/ComponentHelper.php:361
12 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT/libraries/src/Application/SiteApplication.php:218
13 | Joomla\CMS\Application\SiteApplication->dispatch() | JROOT/libraries/src/Application/SiteApplication.php:261
14 | Joomla\CMS\Application\SiteApplication->doExecute() | JROOT/libraries/src/Application/CMSApplication.php:306
15 | Joomla\CMS\Application\CMSApplication->execute() | JROOT/includes/app.php:58
16 | require_once() | JROOT/index.php:32
17 | require() | /xxx/.composer/vendor/laravel/valet/server.php:110

After switching off the hikashop plugin the content plugin is also experiencing the same issue:

Joomla\Plugin\Finder\Content\Extension\Content::onFinderAfterDelete(): Argument #1 ($event) must be of type Joomla\CMS\Event\Finder\AfterDeleteEvent, Joomla\Event\Event given, called in /Users/derekbuntin/Websites/orajin/libraries/vendor/joomla/event/src/Dispatcher.php on line 454

1 | () | JROOT/plugins/finder/content/src/Extension/Content.php:145
2 | Joomla\Plugin\Finder\Content\Extension\Content->onFinderAfterDelete() | JROOT/libraries/vendor/joomla/event/src/Dispatcher.php:454
3 | Joomla\Event\Dispatcher->dispatch() | JROOT/administrator/components/com_easysocial/includes/compatibility.php:783
4 | ESDispatcher::trigger() | JROOT/administrator/components/com_easysocial/includes/video/video.php:2674
5 | SocialVideo->delete() | JROOT/components/com_easysocial/controllers/videos.php:186
6 | EasySocialControllerVideos->delete() | JROOT/libraries/src/MVC/Controller/BaseController.php:730
7 | Joomla\CMS\MVC\Controller\BaseController->execute() | JROOT/components/com_easysocial/controllers/controller.php:67
8 | EasySocialController->execute() | JROOT/components/com_easysocial/easysocial.php:100
9 | require_once() | JROOT/libraries/src/Dispatcher/LegacyComponentDispatcher.php:71
10 | Joomla\CMS\Dispatcher\LegacyComponentDispatcher::Joomla\CMS\Dispatcher\{closure}() | JROOT/libraries/src/Dispatcher/LegacyComponentDispatcher.php:73
11 | Joomla\CMS\Dispatcher\LegacyComponentDispatcher->dispatch() | JROOT/libraries/src/Component/ComponentHelper.php:361
12 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT/libraries/src/Application/SiteApplication.php:218
13 | Joomla\CMS\Application\SiteApplication->dispatch() | JROOT/libraries/src/Application/SiteApplication.php:261
14 | Joomla\CMS\Application\SiteApplication->doExecute() | JROOT/libraries/src/Application/CMSApplication.php:306
15 | Joomla\CMS\Application\CMSApplication->execute() | JROOT/includes/app.php:58
16 | require_once() | JROOT/index.php:32
17 | require() | /xxx/.composer/vendor/laravel/valet/server.php:110

I'll ask EasySocial to have another look at this.

@DerekBuntin thanks for the trace. It confirms that the bug is in EasySocial ESDispatcher::trigger()

Ok, so I'm closing this issue, since it is a third party issue.