[#43058] - [5.1] Dialog: aria-label for Close button is not translated
- Fixed in Code Base
- 17 Mar 2024
- Medium
- Build: 5.1-dev
- # 43058
- Diff
- brianteeman:publich_close
User tests: Successful: Unsuccessful:
Pull Request for Issue #42301 .
Summary of Changes
Changes hadr coded english to a translatable string wioth fallback
Testing Instructions
npm run build:js or use a prebuilt package
Enable Debug Language.
Edit an article.
Under Publishing tab > Created by, click user icon to display the modal dialog.
Using Web Developer Tools, select the Close button to inspect it.
Actual result BEFORE applying this Pull Request
aria-label="**Close**"
Expected result AFTER applying this Pull Request
<button type="button" aria-label="Close" class="button-close btn-close" data-button-close=""></button>
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
I have tested this item ✅ successfully on 6bef5cd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43058.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43058.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-17 12:56:27 |
| Closed_By | ⇒ | bembelimen |
Thx
I have tested this item ✅ successfully on 28ab937
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43058.