[#42986] - [5.1] Dark Mode final Version
- Fixed in Code Base
- 11 Mar 2024
- Medium
- Build: 5.1-dev
- # 42986
- Diff
- coolcat-creations:dark-mode-5.1-dev-final
User tests: Successful: Unsuccessful:
This is a follow up of #42757 and #42010 for Joomla 5.1
Summary of Changes
Dark mode modifications and improvements
Testing Instructions
Turn on dark mode in your browser or O/S
Actual result BEFORE applying this Pull Request
old dark mode
Expected result AFTER applying this Pull Request
improved dark mode
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_banners com_content com_finder com_installer com_languages com_tags com_templates com_users com_workflow Language & Strings Modules Templates (admin) JavaScript Repository NPM Change |
| Labels |
Added:
Language Change
NPM Resource Changed
PR-5.1-dev
|
||
Maybe its my eyes but in dark mode on the system page the horizontal lines look odd. If there is to be a difference I would have expected the stronger line on the head. In light mode there doesnt appear to be any difference in the horizontal lines
grrh cache
@brianteeman thats very odd, for me it looks like this (completely different to yours?!)
sorry for the noise that was a cacje issue
No Problem, thank you for testing!
placeholder font size and weight - changed?
before this pr
with this pr
Go to System > Administrator Templates
Click Atum Details and Files.
Click Create Child Template, Manage Folders, and New File buttons.
See buttons in white.
Multilingual Associations in dark mode is not showing tinymce toolbar in dark
RTL is fubar
Before PR
With PR
Before PR
With PR
at a guess I would think its related to usign the wrong select svg - note that its broken before this PR as well its just not as obvious
richard67
-
@brianteeman I fixed the issue with the select
All new issues fixed. Only the editor issue I am not sure if its template related or plugin related?
from what I can see the editor is correct in dark mode in all the other instances
I really dont know what causes the editor issue in multilang and what the "skin.css" is controlled by
on care duty right now. will take another look tonight
Create a GET Request scheduled task.
Click Run Test button.
Sorry that was a mistake in my text, i meant link color on dark and white on link color. Cassiopeia is totally unrelated to the backend template.
I do not understand why there is a link in the dark theme in 2 varieties. I probably don't understand what this is about. But I wanted to suggest just changing the main color of the links to a lighter one, as I invented here #42757
If this is not possible. I will ask you to add this to the future PR plan according to the template.
Sorry that was a mistake in my text, i meant link color on dark and white on link color. Cassiopeia is totally unrelated to the backend template.
I do not understand why there is a link in the dark theme in 2 varieties. I probably don't understand what this is about. But I wanted to suggest just changing the main color of the links to a lighter one, as I invented here #42757
If this is not possible. I will ask you to add this to the future PR plan according to the template.
already changed to your suggestion yesterday
Install a language.
Change the loading background color.
Install a language. Change the loading background color.
Thats unfortunately a no fix for this PR - seems thats more complicated
LTR
RTL
Same issue repeated in dark mode
LTR
RTL
Same issue repeated in dark mode
Go to Media Manager.
Click Create New Folder button.
Click Rename.
Both have white buttons.
Install the plugin.
Go to Extensions.
Find switch.
Click a button under Version.
LTR
RTL
Same issue repeated in dark mode
fixed for darkmode, lightmode needs to go into separate PR
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-11 00:58:23 |
| Closed_By | ⇒ | LadySolveig |
Thank you very much for the great work and your commitment @coolcat-creations and @MacJoom ! ? ?
Many thanks also to all those who participated in testing and provided feedback - great to see this wonderful collaboration.
System --> Guided Tours, when hovering the cursor
@Kostelano thank you for the finding. As this is merged, can you please open a new issue ?
#42757 (comment)