RTC bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar conseilgouz
conseilgouz
1 Mar 2024

( see discussion #42920) and #42933

Summary of Changes

When vote plugin is enabled, Rich results are created but are rejected by Google Rich Results tool.

Testing Instructions

Enable Vote plugin.
Enable Voting in Articles component configuration.
Vote for one or more articles.
Check your article using https://search.google.com/test/rich-results

Actual result BEFORE applying this Pull Request

Google Rich Results check gives an error
Review snippets shows 2 errors :
rich_snippet_error

Expected result AFTER applying this Pull Request

Google Rich Results check is OK
rich_snippet_ok

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar conseilgouz conseilgouz - open - 1 Mar 2024
avatar conseilgouz conseilgouz - change - 1 Mar 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Mar 2024
Category Front End Plugins
avatar conseilgouz conseilgouz - change - 1 Mar 2024
Labels Added: PR-4.4-dev
avatar conseilgouz
conseilgouz - comment - 1 Mar 2024

@sandewt PR moved to 4.4 branch.
Please test https://issues.joomla.org/tracker/joomla-cms/42934

avatar ManuelVoileux ManuelVoileux - test_item - 1 Mar 2024 - Tested successfully
avatar ManuelVoileux
ManuelVoileux - comment - 1 Mar 2024

I have tested this item ✅ successfully on 2f594e4

I have experienced the same issue.
I have activated the Vote plugin, and I have used vote on an article.
When I check with the Google validation tool I get a critical error. itemReviewed field missing.
Google error test

AFTER applying this Pull Request I got green light from Google
OK Google index

As Fedik mentionned Add the layout with Schema plugin so that no additionnal shema type (such as Product) is involved


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42934.

avatar fgsw fgsw - test_item - 2 Mar 2024 - Tested successfully
avatar fgsw
fgsw - comment - 2 Mar 2024

I have tested this item ✅ successfully on 2f594e4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42934.

avatar conseilgouz
conseilgouz - comment - 2 Mar 2024

As Fedik mentionned Add the layout with Schema plugin so that no additionnal shema type (such as Product) is involved

Schema plugins have been introduced in Joomla 5.0 and this PR is due to work with Joomla 4.4.

avatar ManuelVoileux
ManuelVoileux - comment - 2 Mar 2024

You are right, sorry for the mistake.
What is the appropriate process to have a J5 branch to solve this bug ?

avatar conseilgouz
conseilgouz - comment - 2 Mar 2024

You are right, sorry for the mistake. What is the appropriate process to have a J5 branch to solve this bug ?

It will be to move aggregatingRating into schema plugins, as each schema type has its own required fields list.

avatar sandewt
sandewt - comment - 2 Mar 2024

for your information: Schema.org Product type plugin #42710

avatar conseilgouz
conseilgouz - comment - 2 Mar 2024

for your information: Schema.org Product type plugin #42710

Thank you for this information.

This PR is trying to fix an issue in vote plugin, it's not to create a schemaorg product plugin.

As stated in #42933 , I found we could make aggregateRating work by using product type.

In J5, I think we'll have to fix it another way, maybe through existing schemaorg plugins.

avatar sandewt
sandewt - comment - 3 Mar 2024

Review versus Product ?

see #42933 (comment)

avatar Fedik
Fedik - comment - 3 Mar 2024

Sorry, the changes still incorrect. We should not force any itemscope in to the rating layout,
It can be rendered as part of already defined itemscope. User can already have Article layout override with custom itemscope. This changes will break his schema.

In the end, this hack replaces one problem to another.

For proper fix check the coments in PR for 5.1 (#42933 (comment))

avatar conseilgouz
conseilgouz - comment - 3 Mar 2024

Review versus Product ?

see #42933 (comment)

Review requires a single user, rating count will disappear.

avatar conseilgouz
conseilgouz - comment - 3 Mar 2024

For proper fix check the coments in PR for 5.1

I'm trying to implement 5.1 version of this hack using schemaorg plugins.

I have a doubt on where to implement this.

For example, for Recipe, I added some lines into plugins/schema/recipe/src/Extension/Recipe.php so it added Recipe dedicated rating lines to the Recipe information. I created a new class SchemaorgPrepareRecipeAggregateRating in libraries/src/Schemaorg.

Does it sound correct or is there a better place to add this, using isPartOf maybe ?

avatar sandewt
sandewt - comment - 3 Mar 2024

I'm trying to implement 5.1 version of this hack using schemaorg plugins.

Sorry, but I think it's better to focus on J4 here and not J5.

avatar Fedik
Fedik - comment - 3 Mar 2024

I'm trying to implement 5.1 version of this hack using schemaorg plugins.

In theory the voting plugin should listen to onSchemaBeforeCompileHead and apend the rating data.

avatar bembelimen
bembelimen - comment - 3 Mar 2024

I'm trying to implement 5.1 version of this hack using schemaorg plugins.

In theory the voting plugin should listen to onSchemaBeforeCompileHead and apend the rating data.

Exactly that

avatar exlemor exlemor - test_item - 21 Apr 2024 - Tested successfully
avatar exlemor
exlemor - comment - 21 Apr 2024

I have tested this item ✅ successfully on 07d5eed

Hi @conseilgouz, I just tested this successfully just now.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42934.

avatar conseilgouz
conseilgouz - comment - 22 Apr 2024

Hi Emmanuel,
Thank you for your test.
For this PR, there already were 2 human tests by @fgsw and @ManuelVoileux, but they disappeared from the counter.

avatar alikon alikon - change - 22 Apr 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 22 Apr 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42934.

avatar MacJoom MacJoom - change - 27 Apr 2024
Labels Added: RTC bug
avatar MacJoom MacJoom - change - 27 Apr 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-04-27 15:38:35
Closed_By MacJoom
avatar MacJoom MacJoom - close - 27 Apr 2024
avatar MacJoom MacJoom - merge - 27 Apr 2024
avatar MacJoom
MacJoom - comment - 27 Apr 2024

Thank you!

avatar sandewt
sandewt - comment - 30 May 2024

Sorry but this PR is not correct because the Number of Votes will never be visible.
Because the class is: class="visually-hidden".

Solution move the closing </div

Add a Comment

Login with GitHub to post a comment