Thanks for raising hand.

This fix works with Joomla! 5.0 but, as there won't be any more 5.0 release, I put it in 5.1 branch.

I have experienced the same issue.
I have activated the Vote plugin, and I have used vote on an article.
When I check with the Google validation tool I get a critical error. itemReviewed field missing.

AFTER applying this Pull Request I got green light from Google

This issue also concerns Joomla 4.

AFTER applying this Pull Request I got green light from Google

@ManuelVoileux Does that mean a successful test? If so, please go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/42933 and mark your test result by using the blue "Test this" button at the top left corner, then selecting the appropriate test result (success) and submit.

Every pull request needs 2 successful human tests, and it needs to submit the test result with the issue tracker so the tests are properly counted.

Thanks in advance.

This issue also concerns Joomla 4.

@conseilgouz If this is right, it would need to make this pull request for the 4.4-dev branch. Later maintainers will merge it up into the 5.1-dev branch when the 4.4-dev PR will have been tested and merged.

This solution is correct for J4 which uses itemprop etc
This solution is not correct for J5 which used jsonld

I have tested this item ✅ successfully on ceb86b1

Not that easy.

The page does not contain Product, how it can have the product rating then?
I mean having an empty Product is invalid also.

Just try https://search.google.com/test/rich-results?hl=en

<div itemscope="itemscope" itemtype="https://schema.org/Product"> 
<p class="visually-hidden" itemprop="aggregateRating" itemscope itemtype="https://schema.org/AggregateRating">
   <meta itemprop="ratingCount" content="5">
   <meta itemprop="worstRating" content="1">
   <span itemprop="ratingValue">5</span>
   <span itemprop="bestRating">5</span>
</p>
</div>

It will ask you for full product information.

A better fix would be to remove all HTML schema from layout plugins/content/vote/tmpl/rating.php
And add it with schema plugin, as part of the content schema.

Not that easy.
The page does not contain Product, how it can have the product rating then? I mean having an empty Product is invalid also.
Just try https://search.google.com/test/rich-results?hl=en

<div itemscope="itemscope" itemtype="https://schema.org/Product"> ...  </div>

It will ask you for full product information.

If the Schema tab is filled in, the itemscope, itemtype should be taken from the schema type, and the rating result should be merged in the schema output.

If the Schema tab is filled in, the itemscope, itemtype should be taken from the schema type, and the rating result should be merged in the schema output.

Correct, that what I mean in #42933 (comment)

The page does not contain Product, how it can have the product rating then?

I had a doubt about Product type. This idea comes from JED pages : if you take a look at https://extensions.joomla.org/extension/cg-isotope/ source code, it's done this way and Google search gives me nice stars.

This issue also concerns Joomla 4.

@conseilgouz If this is right, it would need to make this pull request for the 4.4-dev branch. Later maintainers will merge it up into the 5.1-dev branch when the 4.4-dev PR will have been tested and merged.

Same code, same issue in Joomla 4.4.

@richard67 : is 4.4-dev PR a new PR ?

@conseilgouz You can rebase this PR here by changing the base branch with use of the "Edit" button right beside the title on GitHub, or you make a new one for the 4.4-dev branch, whatever is easier for you.

closed, move to 4.4-dev branch #42934

closed, move to 4.4-dev branch #42934

You could have changed the branche here to move to 4.4

I had a doubt about Product type. This idea comes from JED pages : if you take a look at
https://extensions.joomla.org/extension/cg-isotope/ source code, it's done this way and Google search gives me nice stars.

No, that not correct example.
That whole page is about Product, and there it is correct.
Hovewer what you trying here, is incorect, sorry. Because here no product exists.

No, that not correct example.
That whole page is about Product, and there it is correct.
Hovewer what you trying here, is incorect, sorry. Because here no product exists.

Product is a generic type, it could be anything : https://schema.org/Product

In JED page, I did not find any other schema.org line other than reviews and aggregateRating, and Google seems to be happy with this.

You could have changed the branche here to move to 4.4

I tried but I broke it (I'm not a great github user).

Product is a generic type, it could be anything : https://schema.org/Product

It may be more applicable to use ?

<div itemprop="review" itemscope itemtype="https://schema.org/Review">

instead of:

<div itemprop="review" itemscope itemtype="https://schema.org/Product">

Customer reviews: (Microdata)
see: https://schema.org/reviewCount
see: https://schema.org/Rating

See examples

Just to make sure I'm going the correct way, I created a new plugin plugins/schemaorg/aggregaterating.

It adds aggregaterating infos to Recipe type in Json+ld format.
For other types, it adds an aggregateRating lines with product type.

If it sounds correct, I'll continue adding AggregateRating to other schemaorg types.

Please see #42699 for an example of all the other changes that you need to make to add this new plugin

You should not add a new plugin, the existing plugin should do what @Fedik said here: #42934 (comment)

You should not add a new plugin, the existing plugin should do what @Fedik said here: #42934 (comment)

sounds easier

Just added Book/Event/Organization types.
After some more testings, JobPosting and Person types are not supposed to have aggregaterating infos.

Added schemaorg type Article

That looks better, thanks.
Couple notes:

Please remove the traits, they are not reusable in this implementation. Just keep that code withing the plugin itself.
Add full list of schemes which support aggregateRating https://schema.org/AggregateRating:

Brand, CreativeWork, Event, Offer, Organization, Place, Product, Service

@conseilgouz FYI: It is not necessary to keep updating the branch as it will also reset test results that maintainers have to restore. This will save you/maintainers time. Thank you.

I have tested this item ✅ successfully on 556e59e

I was able to replicate successfully the Expected results of Google Rich Results check is OK (and had the error prior to patch).

I have tested this item ✅ successfully on 556e59e

RTC

I have tested this item ✅ successfully on 556e59e

Tested successfully. applied patch and fixed the issue

I have tested this item ✅ successfully on 556e59e

@cybersalt @growunder Thank you for your test.
@exlemor and @viocassel already made "human tests", so now we have 4 positive tests.
Unfortunately, Fedik made this a new feature instead of a bug (why ?), so, even if is RTC, it won't be released with 5.1, may be in 5.2...
Pascal

This pull request has been automatically rebased to 5.2-dev.

Thanks @conseilgouz !