PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Kostelano
Kostelano
29 Feb 2024

Pull Request for Issue # .

  1. Enable the System - Privacy Consent plugin,
  2. Create a user and authorize them in the front. The site will require consent.
  3. Go to the admin panel to the Privacy: Consents page:

Broken subject of consent + when revoking consent, incorrect message.

Actual result BEFORE applying this Pull Request

Screenshot_1

Expected result AFTER applying this Pull Request

Screenshot_2

avatar Kostelano Kostelano - open - 29 Feb 2024
avatar Kostelano Kostelano - change - 29 Feb 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Feb 2024
Category Administration Front End Plugins
avatar brianteeman brianteeman - test_item - 29 Feb 2024 - Tested successfully
avatar brianteeman
brianteeman - comment - 29 Feb 2024

I have tested this item ✅ successfully on 1505082


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42927.

avatar brianteeman brianteeman - alter_testresult - 29 Feb 2024 - brianteeman: Not tested
avatar brianteeman brianteeman - test_item - 29 Feb 2024 - Tested successfully
avatar brianteeman
brianteeman - comment - 29 Feb 2024

I have tested this item ✅ successfully on 1505082


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42927.

avatar ceford
ceford - comment - 2 Mar 2024

I have a problem with this PR. The screenshot for no patch shows a language key under Subject. For with patch it shows the translated key. For me it shows the language key with the patch applied. And the diff does not show any code fix for the Privacy: Consents list.

avatar brianteeman
brianteeman - comment - 2 Mar 2024

@ceford It can be a bit confusing. Before this pr you get the untranslated subject and the wrong text in the body. After this PR any NEW consent requests will egt the translated subject and correct body. The key thing is this PR doesnt change existing requests - only new ones

avatar ceford
ceford - comment - 2 Mar 2024

@brianteeman Thanks for the explanation. However I still have a problem. My consents list has four entries, all for the same test account. The ones created without the patch applied have the Subject text key and the ones with the patch applied have the Subject text value. Only one is active - the Subject is Privacy Policy.

However: I am stuck on my Profile page after login. In the list of queries I see this:

SELECT COUNT(*)
FROM `v1rdc_privacy_consents`
WHERE `user_id` = :userid AND `subject` = 'PLG_SYSTEM_PRIVACYCONSENT_SUBJECT' AND `state` = 1

So the patch has broken my test site. The query comes from /plugins/system/privacyconsent/src/Extension/PrivacyConsent.php:395 unless there is another PR that fixes that query.

Each time I select IPrivacy Policy / I Agree and submit the form a new row is added to the consents table.

avatar Kostelano Kostelano - change - 3 Mar 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-03-03 10:28:56
Closed_By Kostelano
Labels Added: PR-5.1-dev
avatar Kostelano Kostelano - close - 3 Mar 2024

Add a Comment

Login with GitHub to post a comment