User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Broken subject of consent + when revoking consent, incorrect message.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Front End Plugins |
I have tested this item ✅ successfully on 1505082
I have a problem with this PR. The screenshot for no patch shows a language key under Subject. For with patch it shows the translated key. For me it shows the language key with the patch applied. And the diff does not show any code fix for the Privacy: Consents list.
@ceford It can be a bit confusing. Before this pr you get the untranslated subject and the wrong text in the body. After this PR any NEW consent requests will egt the translated subject and correct body. The key thing is this PR doesnt change existing requests - only new ones
@brianteeman Thanks for the explanation. However I still have a problem. My consents list has four entries, all for the same test account. The ones created without the patch applied have the Subject text key and the ones with the patch applied have the Subject text value. Only one is active - the Subject is Privacy Policy.
However: I am stuck on my Profile page after login. In the list of queries I see this:
SELECT COUNT(*)
FROM `v1rdc_privacy_consents`
WHERE `user_id` = :userid AND `subject` = 'PLG_SYSTEM_PRIVACYCONSENT_SUBJECT' AND `state` = 1
So the patch has broken my test site. The query comes from /plugins/system/privacyconsent/src/Extension/PrivacyConsent.php:395 unless there is another PR that fixes that query.
Each time I select IPrivacy Policy / I Agree and submit the form a new row is added to the consents table.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-03 10:28:56 |
Closed_By | ⇒ | Kostelano | |
Labels |
Added:
PR-5.1-dev
|
I have tested this item ✅ successfully on 1505082
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42927.