Joomla! Issue Tracker | Joomla! CMS #42926 - [5.1] replace app property in SEF plugin

PR-5.1-dev

Closed
4 Mar 2024
Medium
Build: 5.1-dev
# 42926
Diff
heelc29:5.1/followup-42702

Pending

Pending continuous-integration/drone/pr Build is pending Details

User tests: Successful: Unsuccessful:

heelc29
29 Feb 2024

Followup Pull Request for PRs #42702 and #42704 . @Hackwar

Summary of Changes

replace extra app property and replace with injected application due service provider

Testing Instructions

check new options (#42702 and #42704) are still working as expected

Actual result BEFORE applying this Pull Request

app property in plugins are deprecated

joomla-cms/libraries/src/Plugin/CMSPlugin.php

Lines 137 to 145 in 8da0b7c

    
           if (property_exists($this, 'app')) { 
        
               @trigger_error('The application should be injected through setApplication() and requested through getApplication().', E_USER_DEPRECATED); 
        
               $reflection  = new \ReflectionClass($this); 
        
               $appProperty = $reflection->getProperty('app'); 
        
               if ($appProperty->isPrivate() === false && \is_null($this->app)) { 
        
                   $this->app = Factory::getApplication(); 
        
               } 
        
           }

Expected result AFTER applying this Pull Request

no deprecated app property is used in sef plugin

Link to documentations

Please select:

No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed

341af56 29 Feb 2024

[5.1] replace app property in sef plugin

heelc29 - open - 29 Feb 2024

heelc29 - change - 29 Feb 2024

Status

New

⇒

Pending

joomla-cms-bot - change - 29 Feb 2024

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#42926] - [5.1] replace app property in SEF plugin