RTC bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
29 Feb 2024

Pull Request for Issue #42889

Summary of Changes

Same as #41463 but for highlight plugin

Testing Instructions

In testing installation.
In Smart Search config set "Word Match" to "Match words containing the search term anywhere".
Go to search page, and search for joomla 1.
Notice the length of the link for each search result.

Actual result BEFORE applying this Pull Request

it is long

Expected result AFTER applying this Pull Request

it is shorter

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 29 Feb 2024
avatar Fedik Fedik - change - 29 Feb 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Feb 2024
Category Front End Plugins
avatar Fedik Fedik - change - 29 Feb 2024
The description was changed
avatar Fedik Fedik - edited - 29 Feb 2024
avatar ceford ceford - test_item - 29 Feb 2024 - Tested successfully
avatar ceford
ceford - comment - 29 Feb 2024

I have tested this item ✅ successfully on 84c7fde


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42921.

avatar Fedik Fedik - change - 29 Feb 2024
The description was changed
avatar Fedik Fedik - edited - 29 Feb 2024
avatar viocassel viocassel - test_item - 29 Feb 2024 - Tested successfully
avatar viocassel
viocassel - comment - 29 Feb 2024

I have tested this item ✅ successfully on 84c7fde


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42921.

avatar Quy Quy - change - 29 Feb 2024
Status Pending Ready to Commit
Labels Added: bug PR-4.4-dev
avatar Quy
Quy - comment - 29 Feb 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42921.

avatar Hackwar
Hackwar - comment - 1 Mar 2024

Sorry, but we have this already in the layout of smart search. https://github.com/joomla/joomla-cms/blob/4.4-dev/components/com_finder/tmpl/search/default_results.php#L64

I don't think it is useful to duplicate this code here as well.

avatar Fedik
Fedik - comment - 1 Mar 2024

@Hackwar nope, it is diferent, it is for URL. What is in your PR is for JavaScript.

avatar laoneo laoneo - change - 4 Mar 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-04 15:45:19
Closed_By laoneo
Labels Added: RTC
avatar laoneo laoneo - close - 4 Mar 2024
avatar laoneo laoneo - merge - 4 Mar 2024
avatar laoneo
laoneo - comment - 4 Mar 2024

Thanks!

Add a Comment

Login with GitHub to post a comment