[#42907] - [5.2] Static function getList deprecated in mod_stats
- Fixed in Code Base
- 7 May 2024
- Medium
- Build: 5.1-dev
- # 42907
- Diff
- joomlaweby:mod_stats_fix
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Static function getList is after applying pull request deprecated and new non-static method getStats created in StatsHelper.
Testing Instructions
- Make sure you have site module mod_stats published
- You should see module output on frontend
- Deprecated static function getList should also work
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
My Installation Setting:
Better to down- and upload & install every day the nightly build (now Joomla_5.1.0-beta1-dev-Development-Update_Package.zip)?
I have tested this item ✅ successfully on 15ba980
Using nightly build.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.
Just realised I am testing with PHP8.3 - everything seems to work. For this PR I do not see a deprecated notice with or without the patch. Am I supposed to?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.
Just realised I am testing with PHP8.3 - everything seems to work. For this PR I do not see a deprecated notice with or without the patch. Am I supposed to?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.
@ceford No, deprecated static function in helper file may be still used by other extensions (probably only 3rd party), so this is the case, when this deprecated function is called. Module mod_stats is now using new non-static method from helper, so there is no deprecation notice.
I have tested this item ✅ successfully on 15ba980
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Pending |
Back to pending as there have been made changes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.
| Labels |
Removed:
RTC
|
||
I have tested this item ✅ successfully on 1dbe39e
Was successful and noticed that in Joomla Debug, there seems to be fewer Queries after Patch.
Before Patch: 28 statements were executed, 6 of which were duplicates, 22 unique
After Patch: 25 statements were executed, 2 of which were duplicates, 23 unique
so if intended great and even if not, fewer = better so great :)
Thanks for yet another good fix.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.
I have tested this item ✅ successfully on 1dbe39e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.
I have tested this item ✅ successfully on 1dbe39e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42907.
great to see all these tests @cybersalt - hope this will become a regular thing
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
| Labels |
Added:
Feature
RTC
PR-5.2-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-07 09:20:05 |
| Closed_By | ⇒ | pe7er |
Thanks @joomlaweby !
After click on
Apply Patchin Patchtester only a red Message is shown: "The file marked for modification does not exist: modules/mod_stats/src/Dispatcher/Dispatcher.php".