Joomla! Issue Tracker | Joomla! CMS #42906 - [5.1] Followup convert mod

RTC PR-5.1-dev

Fixed in Code Base
29 Feb 2024
Medium
Build: 5.1-dev
# 42906
Diff
heelc29:5.1/followup-42735

Pending

Pending continuous-integration/drone/pr Build is pending Details

User tests: Successful: Unsuccessful:

heelc29
27 Feb 2024

Followup Pull Request for #42735 .

Summary of Changes

Fix the return value in case the exception is caught

Testing Instructions

code review

Old code -> count empty array -> 0:

joomla-cms/administrator/modules/mod_messages/mod_messages.php

Lines 27 to 34 in be506c0

    
           } catch (RuntimeException $e) { 
        
               $messages = []; 
        
               // Still render the error message from the Exception object 
        
               $app->enqueueMessage($e->getMessage(), 'error'); 
        
           } 
        
           $countUnread = \count($messages);

fcb9c2b 27 Feb 2024

[5.1] Followup convert mod_messages to service provider #42735

heelc29 - open - 27 Feb 2024

heelc29 - change - 27 Feb 2024

Status

New

⇒

Pending

joomla-cms-bot - change - 27 Feb 2024

Category

⇒

Modules Administration

Quy - test_item - 27 Feb 2024 - Tested successfully

Quy - comment - 27 Feb 2024

I have tested this item ✅ successfully on fcb9c2b

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42906.}

ceford - test_item - 28 Feb 2024 - Tested successfully

ceford - comment - 28 Feb 2024

I have tested this item ✅ successfully on fcb9c2b

Code review - looks fine to me.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42906.}

Quy - change - 28 Feb 2024

Status	Pending	⇒	Ready to Commit
Labels	Added: PR-5.1-dev

Quy - comment - 28 Feb 2024

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42906.}

bembelimen - change - 29 Feb 2024

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2024-02-29 08:57:42
Closed_By		⇒	bembelimen
Labels	Added: RTC

bembelimen - close - 29 Feb 2024

bembelimen - merge - 29 Feb 2024

bembelimen - comment - 29 Feb 2024

Thank you!

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#42906] - [5.1] Followup convert mod_messages to service provider #42735

Summary of Changes

Testing Instructions

Add a Comment

	} catch (RuntimeException $e) {
	$messages = [];

	// Still render the error message from the Exception object
	$app->enqueueMessage($e->getMessage(), 'error');
	}

	$countUnread = \count($messages);