Feeling Lucky
RTC
NPM Resource Changed
PR-5.1-dev
[#42903] - [5.1] Core loader custom element rework
- Ready to Commit
- Medium
- Build: 5.1-dev
- # 42903
- Diff
- C-Lodder:loader
User tests: Successful: Unsuccessful:
Summary of Changes
This PR has three parts:
- The core loader custom element has been rewritten to use an SVG rather than built using CSS.
- We can now pass
inline="true"andsize="xx", allowing us to have an inline instance, rather than fullscreen. - The sample data module now uses the updated core loader, rather than an old animated GIF.
Why SVG over CSS?
The original CSS version has loads of hardcoded values, meaning scaling became extremely difficult.
Why aren't we observing the inline or size attributes?
Simply because I do not believe they need observing.
Testing Instructions
- Run
npm i - Go to your Joomla backend
- Install the sample data
Screenshot
Thank you to @dgrammatiko for providing the SVG.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
C-Lodder
- comment
- 27 Feb 2024
@dgrammatiko Good catch, fixed.
@Quy Probably not.
Quy
- comment
- 28 Feb 2024
I have tested this item ✅ successfully on ef94d64
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42903.
fgsw
- comment
- 28 Feb 2024
I have tested this item ✅ successfully on ef94d64
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42903.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 28 Feb 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42903.
| Labels |
Added:
RTC
|
||
Would you consider this to be a fix for #31078 #30099?