[#42882] - [4.4] Fix of unnecessary SQL query for Fields, get the field value already loaded by getFields()
- Closed
- 7 Mar 2024
- Medium
- Build: 4.4-dev
- # 42882
- Diff
- Fedik:fields-fix2
User tests: Successful: Unsuccessful:
Summary of Changes
The same as #42861 but for j4
Remove unnecessary SQL query for the custom fields, during the form rendering.
FieldsHelper::getFields() load the field value, however FieldsHelper::prepareForm() also loading them wthout a reason.
Also removed some dead code.
Testing Instructions
Enable debug and debug query.
Create a couple of Custom fields, let say 10.
Open article editing.
Actual result BEFORE applying this Pull Request
Notice amount of query in debug.
Let say 75
Expected result AFTER applying this Pull Request
The amount of query will be 10 less, 65
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Title |
|
||||||
Does this also work when you fetch two articles within the same request. Pretty sure the second article gets the same rawvalue as the first one.
Nope
joomla-cms/administrator/components/com_fields/src/Helper/FieldsHelper.php
Lines 179 to 185 in d272577
Every time you call FieldsHelper::getFields it will load new values.
I have tested this item ✅ successfully on e5e307b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42882.
I have tested this item ✅ successfully on e5e307b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42882.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42882.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-4.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42882.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-07 09:13:50 |
| Closed_By | ⇒ | Fedik | |
| Labels |
Added:
RMDQ
|
||
@crommie @chmst @adj9 As you had tested PR #42861 , could you test this one here, too? It's the same as the other one, just for 4.4 instead of 5.1. Thanks in advance.