Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42881] - [5.1] Give a name for the breadcrumbs schema.org asset

RTC PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
25 Feb 2024

Summary of Changes

The PR gives a name for the breadcrumbs asset for schema.org,
By default the name is md5 of the asset content, wich is not very useful for this asset.
Specific name will allow others extensions easily access to it.

Testing Instructions

Apply patch, visit the page with the breadcrumbs.
Check page source, and make sure BreadcrumbList schema is there.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 25 Feb 2024
avatar Fedik Fedik - change - 25 Feb 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2024
Category ⇒ Modules Front End
avatar ceford
ceford - comment - 27 Feb 2024

I may have done something wrong - the original and patch produce identical output:

<script type="application/ld+json">{
    "@context": "https://schema.org",
    "@type": "BreadcrumbList",
    "@id": "http://localhost/joomla-cms5/#/schema/BreadcrumbList/17",
    "itemListElement": [
        {
            "@type": "ListItem",
            "position": 1,
            "item": {
                "@id": "http://localhost/joomla-cms5/",
                "name": "Home"
            }
        },
        {
            "@type": "ListItem",
            "position": 2,
            "item": {
                "@id": "http://localhost/joomla-cms5/testing-home-1.html",
                "name": "Testing Home"
            }
        },
        {
            "@type": "ListItem",
            "position": 3,
            "item": {
                "name": "Lorem Ipsum"
            }
        }
    ]
}</script>

Can that be right?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42881.

avatar Fedik
Fedik - comment - 27 Feb 2024

Yes, it should be the same. It should work as before.
The changes is invisiblle for the user.

avatar ceford ceford - test_item - 27 Feb 2024 - Tested successfully
avatar ceford
ceford - comment - 27 Feb 2024

I have tested this item ✅ successfully on 24a4de1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42881.

avatar viocassel viocassel - test_item - 27 Feb 2024 - Tested successfully
avatar viocassel
viocassel - comment - 27 Feb 2024

I have tested this item ✅ successfully on 24a4de1

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42881.

avatar alikon alikon - change - 27 Feb 2024
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 27 Feb 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42881.

avatar Quy Quy - change - 27 Feb 2024
Labels Added: PR-5.1-dev RTC
avatar LadySolveig LadySolveig - change - 27 Feb 2024
Labels
avatar LadySolveig LadySolveig - close - 27 Feb 2024
avatar LadySolveig LadySolveig - merge - 27 Feb 2024
avatar LadySolveig LadySolveig - change - 27 Feb 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-02-27 23:10:28
Closed_By ⇒ LadySolveig
avatar LadySolveig
LadySolveig - comment - 27 Feb 2024

Thank you @Fedik and also for testing @ceford @viocassel

Add a Comment

Login with GitHub to post a comment