[#42820] - [4.4] Fix help icon not opening help screen
- Fixed in Code Base
- 22 Feb 2024
- Medium
- Build: 4.4-dev
- # 42820
- Diff
- Quy:42818-help-icon
User tests: Successful: Unsuccessful:
Pull Request for Issue #42818 .
Summary of Changes
Help icon fails to open help screen when clicked on the question mark.
Thanks @dgrammatiko for the solution.
Testing Instructions
Go to any screen which has a help screen, for example Content -> Articles.
Click on the text "Help" of the help toolbar button and you will see the appropriate help screen. However, if you click on the question mark to the left of the text you will get a much larger blank window with "about:blank" in the address bar.
Download the prebuilt package.
or
Apply PR and run npm run build:js
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
I have tested this item ✅ successfully on 7a13d66
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42820.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
bug
PR-4.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42820.
Please don't use CSS to fix a JS problem
You should be using currentTarget, rather than target instead:
https://github.com/joomla/joomla-cms/blob/4.4-dev/build/media_source/legacy/js/toolbar.es5.js#L46
E.g you want to target the element that the event is attached to (button), rather than trying to target the element that you clicked, which in this case (the icon), has no event attached to it.
| Status | Ready to Commit | ⇒ | Pending |
| Category | Repository NPM Change | ⇒ | JavaScript Repository NPM Change |
I have tested this item ✅ successfully on 92a1cf4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42820.
I have tested this item ✅ successfully on 92a1cf4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42820.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42820.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-22 12:37:02 |
| Closed_By | ⇒ | MacJoom |
Thank you!
I have tested this item ✅ successfully on 7a13d66
with NPM Prebuilt Package
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42820.