Feeling Lucky
RTC
PR-5.1-dev
[#42792] - [5.1] Convert mod_wrapper to service provider
- Fixed in Code Base
- 25 Feb 2024
- Medium
- Build: 5.1-dev
- # 42792
- Diff
- joomlaweby:mod_wrapper
User tests: Successful: Unsuccessful:
Summary of Changes
Converts the wrapper module to service provider.
Testing Instructions
- Make sure you have site module mod_wrapper published and configured
- You should see module output on frontend
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
PR-5.1-dev
|
||
fgsw
- comment
- 13 Feb 2024
I have tested this item ✅ successfully on 62151be
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.
ceford
- comment
- 21 Feb 2024
I have tested this item ✅ successfully on 4706e0b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.
viocassel
- comment
- 21 Feb 2024
I have tested this item ✅ successfully on 4706e0b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 22 Feb 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42792.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-25 22:06:59 |
| Closed_By | ⇒ | LadySolveig |
LadySolveig
- comment
- 25 Feb 2024
Thank you @joomlaweby and also testing and review @sandewt @fgsw @viocassel @ceford
joomla-cms/modules/mod_wrapper/src/Helper/WrapperHelper.php
Line 35 in c74906e
public static function getParams(&$params)is deprecated will be removed in 6.0Please change this function to a non-static function.