[#42791] - [5.1] Convert mod_feed to service provider
- Closed
- 18 Feb 2024
- Medium
- Build: 5.1-dev
- # 42791
- Diff
- joomlaweby:mod_feed
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Converts the feed module to service provider.
Testing Instructions
- Make sure you have site module mod_feed published and configured
- You should see module output on frontend
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
PR-5.1-dev
|
||
I have tested this item ✅ successfully on 5325757
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42791.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42791.
| Labels |
Added:
RTC
|
||
I suggest for PR a label Ready to test, assigned by maintainers, to reduce the number of re-tests.
I'm still missing the conversion of the FeedHelper.php file.
The public static function getFeed($params) becomes deprecated, just like you changed the other modules
| Labels |
Removed:
RTC
|
||
I'm still missing the conversion of the FeedHelper.php file.
The
public static function getFeed($params)becomes deprecated, just like you changed the other modules
I am sorry, somehow I missed it. Now it is fixed.
the joomla-cms bot is kidding me ?
See: Convert mod_feed to service provider #42215
@joomlaweby and @heelc29
Sorry, I realize now that I should have been clearer earlier. Because this PR #42791 is duplicate with #42215.
A decision will have to be made as to what to do next. Which PR takes priority?
I am closing this PR
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-18 19:53:05 |
| Closed_By | ⇒ | joomlaweby | |
| Labels |
Added:
RTC
|
||
@joomlaweby I hope you don't get discouraged? And that you just keep going, because you are doing well with your other PRs.
I have tested this item ✅ successfully on 5325757
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42791.