Feeling Lucky
RTC
NPM Resource Changed
PR-5.1-dev
[#42784] - [5.1] Minor cleanup for modules JS
- Fixed in Code Base
- 26 Feb 2024
- Medium
- Build: 5.1-dev
- # 42784
- Diff
- C-Lodder:modules-js
User tests: Successful: Unsuccessful:
Summary of Changes
As Joomla no longer supports IE11, this PR mainly removes the need for converting a NodeList to an Array, as evergreen browser's implementation of forEach can iterater over a NodeList.
Also includes some other minor tweaks.
Testing Instructions
Code review @dgrammatiko @Fedik
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
Fedik
- comment
- 12 Feb 2024
I have tested this item ✅ successfully on e971d1e
Okay, menu seems still working :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42784.
viocassel
- comment
- 13 Feb 2024
I have tested this item ✅ successfully on e971d1e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42784.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 13 Feb 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42784.
| Labels |
Added:
RTC
NPM Resource Changed
PR-5.1-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-26 23:34:02 |
| Closed_By | ⇒ | LadySolveig |
LadySolveig
- comment
- 26 Feb 2024
Thank you @C-Lodder and for testing @Fedik @viocassel
Looks good from review,
However it would be good to see at least one human test to confirm that the Admin menu still works.